From: Junio C Hamano <gitster@pobox.com>
To: Mike Ralphson <mike.ralphson@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers
Date: Wed, 14 Sep 2016 08:56:18 -0700 [thread overview]
Message-ID: <xmqqeg4mscf1.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <01020157276d4d1f-9c995462-4aea-4949-8d29-3dbdbec77dd7-000000@eu-west-1.amazonses.com> (Mike Ralphson's message of "Wed, 14 Sep 2016 06:40:57 +0000")
Mike Ralphson <mike.ralphson@gmail.com> writes:
> Two instances of %ld being used for unsigned longs.
>
> Signed-off-by: Mike Ralphson <mike.ralphson@gmail.com>
> ---
Good eyes. Thanks for spotting.
> vcs-svn/fast_export.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vcs-svn/fast_export.c b/vcs-svn/fast_export.c
> index bd0f2c2..97cba39 100644
> --- a/vcs-svn/fast_export.c
> +++ b/vcs-svn/fast_export.c
> @@ -73,7 +73,7 @@ void fast_export_begin_note(uint32_t revision, const char *author,
> static int firstnote = 1;
> size_t loglen = strlen(log);
> printf("commit %s\n", note_ref);
> - printf("committer %s <%s@%s> %ld +0000\n", author, author, "local", timestamp);
> + printf("committer %s <%s@%s> %lu +0000\n", author, author, "local", timestamp);
> printf("data %"PRIuMAX"\n", (uintmax_t)loglen);
> fwrite(log, loglen, 1, stdout);
> if (firstnote) {
> @@ -107,7 +107,7 @@ void fast_export_begin_commit(uint32_t revision, const char *author,
> }
> printf("commit %s\n", local_ref);
> printf("mark :%"PRIu32"\n", revision);
> - printf("committer %s <%s@%s> %ld +0000\n",
> + printf("committer %s <%s@%s> %lu +0000\n",
> *author ? author : "nobody",
> *author ? author : "nobody",
> *uuid ? uuid : "local", timestamp);
>
> --
> https://github.com/git/git/pull/293
next prev parent reply other threads:[~2016-09-14 15:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-14 6:40 [PATCH] vcs-svn/fast_export: fix timestamp fmt specifiers Mike Ralphson
2016-09-14 15:56 ` Junio C Hamano [this message]
2016-09-14 19:11 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqeg4mscf1.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mike.ralphson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox