git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Chris Angelico <rosuav@gmail.com>, Kevin <ikke@ikke.info>,
	git <git@vger.kernel.org>
Subject: Re: Configuring a third-party git hook
Date: Fri, 21 Mar 2014 11:54:58 -0700	[thread overview]
Message-ID: <xmqqeh1vtm9p.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140321181532.GC15508@sigill.intra.peff.net> (Jeff King's message of "Fri, 21 Mar 2014 14:15:32 -0400")

Jeff King <peff@peff.net> writes:

> On Fri, Mar 21, 2014 at 10:31:59AM -0700, Junio C Hamano wrote:
>
>> -- >8 --
>> From: Chris Angelico <rosuav@gmail.com>
>> Date: Fri, 21 Mar 2014 15:07:08 +1100
>> Subject: [PATCH] config.txt: third-party tools may and do use their own variables
>> [...]
>> +Other git-related tools may and do use their own variables.  When
>> +inventing new variables for use in your own tool, make sure their
>> +names do not conflict with what are used by Git itself and other
>> +popular tools, and describe them in your documentation.
>
> I think this third line should be "with what _is_ used" to match the
> verb and noun pluralness[1]. Or to keep better parallel structure with
> the first clause, something like "...their names do not conflict with
> those that are used by Git...".

Thanks. I'll amend to do the "those that are".

  parent reply	other threads:[~2014-03-21 18:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-19 11:16 Configuring a third-party git hook Chris Angelico
2014-03-20 12:53 ` Kevin
2014-03-20 16:51   ` Chris Angelico
2014-03-20 23:38     ` Jeff King
2014-03-20 23:46       ` Chris Angelico
2014-03-21  3:43         ` Jeff King
2014-03-21  4:07           ` Chris Angelico
2014-03-21 17:31             ` Junio C Hamano
2014-03-21 17:48               ` Chris Angelico
2014-03-21 18:15               ` Jeff King
2014-03-21 18:53                 ` Junio C Hamano
2014-03-21 18:54                 ` Junio C Hamano [this message]
2014-03-20 16:53 ` Junio C Hamano
2014-03-20 17:10   ` Chris Angelico

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqeh1vtm9p.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ikke@ikke.info \
    --cc=peff@peff.net \
    --cc=rosuav@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).