Git development
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Lorenz Leutgeb <lorenz.leutgeb@posteo.eu>
Subject: Re: [PATCH] doc: remote-helpers: option pushcert if-asked
Date: Mon, 02 Nov 2026 01:01:17 -0800	[thread overview]
Message-ID: <xmqqfqxjmwte.fsf@gitster.g> (raw)
In-Reply-To: <20260829183659.29947-1-lorenz.leutgeb@posteo.eu> (Lorenz Leutgeb's message of "Sat, 29 Aug 2026 18:37:04 +0000")

Lorenz Leutgeb <lorenz.leutgeb@posteo.eu> writes:

> The documentation mentions that the value for the option "pushcert" is
> "true" or "false". This is incomplete, as can be seen by analyzing
> transport-helper.c:1009-1018 (added in commit 30261094b1f7fdcba3b7a1)
> which also implements setting the option to the value "if-asked".
>
> Add the third value to the documentation (added in commit b9299a2bb1).

Except for these commit references not using the --pretty=reference
format, I think the above is good enough, and the patch contents is
true enough.

That's not much of a review, but that needs to suffice for now.

Will mark the topic ready for 'next'.

> Signed-off-by: Lorenz Leutgeb <lorenz.leutgeb@posteo.eu>
> ---
>  Documentation/gitremote-helpers.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/gitremote-helpers.adoc b/Documentation/gitremote-helpers.adoc
> index 39cdece16e..10921e91b9 100644
> --- a/Documentation/gitremote-helpers.adoc
> +++ b/Documentation/gitremote-helpers.adoc
> @@ -523,7 +523,7 @@ set by Git if the remote helper has the 'option' capability.
>  'option update-shallow' {'true'|'false'}::
>  	Allow to extend .git/shallow if the new refs require it.
>  
> -'option pushcert' {'true'|'false'}::
> +'option pushcert' {'true'|'false'|'if-asked'}::
>  	GPG sign pushes.
>  
>  'option push-option' <string>::

      reply	other threads:[~2026-11-02  9:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-29 18:37 [PATCH] doc: remote-helpers: option pushcert if-asked Lorenz Leutgeb
2026-11-02  9:01 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfqxjmwte.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=lorenz.leutgeb@posteo.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox