From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 4/4] worktree add: let worktree_basename() return string copy
Date: Mon, 31 Aug 2026 11:56:41 -0700 [thread overview]
Message-ID: <xmqqfqzuw23a.fsf@gitster.g> (raw)
In-Reply-To: <xmqqjypdj6g4.fsf@gitster.g> (Junio C. Hamano's message of "Wed, 26 Aug 2026 07:35:07 -0700")
Junio C Hamano <gitster@pobox.com> writes:
>>> So going back to the confusing part of the log message,
>>>
>>> Remind ... to worktree_basename_dup(). Among the three callers
>>> of worktree_basename(), two immediately make copies of the
>>> returned string before using and freeing it, which makes for an
>>> easy conversion. Convert the other one from resetting ...
>>>
>>> or something like that, perhaps?
>>
>> Yes.
>
> Thanks. We do not know if other parts of the series gets more
> serious reviews that necessitates an updated version, so in the
> meantime I'll reword what I have locally.
And nothing happened since then. As the topic was in a good shape
except for the confusing part of the log, which we amended in my
tree already, let's mark the topic for 'next'.
prev parent reply other threads:[~2026-08-31 18:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-25 18:03 [PATCH 0/4] worktree add: worktree_basename() fixes René Scharfe
2026-08-25 18:03 ` [PATCH 1/4] worktree add: don't read out of bounds in worktree_basename() René Scharfe
2026-08-25 18:03 ` [PATCH 2/4] worktree add: reject separator-only path René Scharfe
2026-08-25 18:03 ` [PATCH 3/4] worktree add: trim slashes when deriving branch name from path René Scharfe
2026-08-25 19:47 ` Junio C Hamano
2026-08-25 18:03 ` [PATCH 4/4] worktree add: let worktree_basename() return string copy René Scharfe
2026-08-25 20:04 ` Junio C Hamano
2026-08-26 4:37 ` René Scharfe
2026-08-26 14:35 ` Junio C Hamano
2026-08-31 18:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfqzuw23a.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox