From: Junio C Hamano <gitster@pobox.com>
To: Justin Tobler <jltobler@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, peff@peff.net,
luca.stefani.ge1@gmail.com
Subject: Re: [PATCH] object-file: avoid ODB transaction when not writing objects
Date: Tue, 07 Apr 2026 14:53:54 -0700 [thread overview]
Message-ID: <xmqqfr563099.fsf@gitster.g> (raw)
In-Reply-To: <xmqqo6ju31wx.fsf@gitster.g> (Junio C. Hamano's message of "Tue, 07 Apr 2026 14:18:06 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> I'd appreciate it if you can give your eyeballs to the attached to
> see if that is how you would fixed the bug in the original context
> of v2.52 track. If everything looks OK, then there is no need to
> spend time backporting on your side. We have everything necessary.
Another thing. Your jt/odb-transaction-write topic (in 'seen')
already addresses this issue, so we may merge this single patch down
to 'next' and 'master' first, but the merge that brings in the topic
can just supersede this patch, perhaps keeping the test added to
t1517.
Do I understand correctly? The t1517 part of the patch, when
applied to 'seen', does indicate that the problem is not there.
next prev parent reply other threads:[~2026-04-07 21:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 20:17 [PATCH] object-file: avoid ODB transaction when not writing objects Justin Tobler
2026-04-07 21:18 ` Junio C Hamano
2026-04-07 21:29 ` Jeff King
2026-04-07 21:43 ` Junio C Hamano
2026-04-07 21:43 ` Justin Tobler
2026-04-07 21:53 ` Junio C Hamano [this message]
2026-04-07 22:08 ` Justin Tobler
2026-04-07 22:24 ` Junio C Hamano
2026-04-07 22:41 ` Justin Tobler
2026-04-08 0:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfr563099.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jltobler@gmail.com \
--cc=luca.stefani.ge1@gmail.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox