From: Junio C Hamano <gitster@pobox.com>
To: "Alan Braithwaite via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, ps@pks.im, christian.couder@gmail.com,
jonathantanmy@google.com, me@ttaylorr.com,
Jeff King <peff@peff.net>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
Alan Braithwaite <alan@braithwaite.dev>
Subject: Re: [PATCH v4] clone: add clone.<url>.defaultObjectFilter config
Date: Fri, 06 Mar 2026 14:18:17 -0800 [thread overview]
Message-ID: <xmqqfr6cy53q.fsf@gitster.g> (raw)
In-Reply-To: <pull.2058.v4.git.1772833649843.gitgitgadget@gmail.com> (Alan Braithwaite via GitGitGadget's message of "Fri, 06 Mar 2026 21:47:29 +0000")
"Alan Braithwaite via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Alan Braithwaite <alan@braithwaite.dev>
>
> Add a new configuration option that lets users specify a default
> partial clone filter per URL pattern. When cloning a repository
> whose URL matches a configured pattern, git-clone automatically
> applies the filter, equivalent to passing --filter on the command
> line.
>
> [clone "https://github.com/"]
> defaultObjectFilter = blob:limit=5m
>
> [clone "https://internal.corp.com/large-project/"]
> defaultObjectFilter = blob:none
>
> URL matching uses the existing urlmatch_config_entry() infrastructure,
> following the same rules as http.<url>.* — you can match a domain,
> a namespace path, or a specific project, and the most specific match
> wins.
>
> The config only affects the initial clone. Once the clone completes,
> the filter is recorded in remote.<name>.partialCloneFilter, so
> subsequent fetches inherit it automatically. An explicit --filter
> flag on the command line takes precedence.
>
> Only the URL-qualified form (clone.<url>.defaultObjectFilter) is
> honored; a bare clone.defaultObjectFilter without a URL subsection
> is ignored.
Is this still valid? It is inconsistent with the updated
documentation where both clone.defaultObjectFilter and
clone.<url>.defaultObjectFilter are listed.
These iterations of patches may require a bit more careful
proofreading before getting sent to the mailing list for others to
comment on, I suspect?
> Signed-off-by: Alan Braithwaite <alan@braithwaite.dev>
> ---
> ...
> +`clone.defaultObjectFilter`::
> +`clone.<url>.defaultObjectFilter`::
> + When set to a filter spec string (e.g., `blob:limit=1m`,
> + `blob:none`, `tree:0`), linkgit:git-clone[1] will automatically
> + use `--filter=<value>` to enable partial clone behavior.
> + Objects matching the filter are excluded from the initial
> + transfer and lazily fetched on demand (e.g., during checkout).
> + Subsequent fetches inherit the filter via the per-remote config
> + that is written during the clone.
> ++
> +The bare `clone.defaultObjectFilter` applies to all clones. The
> +URL-qualified form `clone.<url>.defaultObjectFilter` restricts the
> +setting to clones whose URL matches `<url>`, following the same
> +rules as `http.<url>.*` (see linkgit:git-config[1]). The most
> +specific URL match wins. You can match a domain, a namespace, or a
> +specific project:
In the test script we see a handful of lines like these
> + test "$(git -C default-filter-blobnone config --local remote.origin.promisor)" = "true" &&
> + test "$(git -C default-filter-blobnone config --local remote.origin.partialclonefilter)" = "blob:none"
added. They may have been written to mimick an existing line in a
test elsewhere, but see efforts by others like
https://lore.kernel.org/git/20260305225128.54283-1-francescopaparatto@gmail.com/
Thanks.
next prev parent reply other threads:[~2026-03-06 22:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-01 16:44 [PATCH] fetch, clone: add fetch.blobSizeLimit config Alan Braithwaite via GitGitGadget
2026-03-02 11:53 ` Patrick Steinhardt
2026-03-02 18:28 ` Jeff King
2026-03-02 18:57 ` Junio C Hamano
2026-03-02 21:36 ` Alan Braithwaite
2026-03-03 6:30 ` Patrick Steinhardt
2026-03-03 14:00 ` Alan Braithwaite
2026-03-03 15:08 ` Patrick Steinhardt
2026-03-03 17:58 ` Junio C Hamano
2026-03-04 5:07 ` Patrick Steinhardt
2026-03-03 17:05 ` Junio C Hamano
2026-03-03 14:34 ` Jeff King
2026-03-05 0:57 ` [PATCH v2] clone: add clone.<url>.defaultObjectFilter config Alan Braithwaite via GitGitGadget
2026-03-05 19:01 ` Junio C Hamano
2026-03-05 23:11 ` Alan Braithwaite
2026-03-06 6:55 ` [PATCH v3] " Alan Braithwaite via GitGitGadget
2026-03-06 10:39 ` brian m. carlson
2026-03-06 19:33 ` Junio C Hamano
2026-03-06 21:50 ` Alan Braithwaite
2026-03-06 21:47 ` [PATCH v4] " Alan Braithwaite via GitGitGadget
2026-03-06 22:18 ` Junio C Hamano [this message]
2026-03-07 1:04 ` Alan Braithwaite
2026-03-07 1:33 ` [PATCH v5] " Alan Braithwaite via GitGitGadget
2026-03-11 7:44 ` Patrick Steinhardt
2026-03-15 1:33 ` Alan Braithwaite
2026-03-15 5:37 ` [PATCH v6] " Alan Braithwaite via GitGitGadget
2026-03-15 21:32 ` Junio C Hamano
2026-03-16 7:47 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfr6cy53q.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alan@braithwaite.dev \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=jonathantanmy@google.com \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox