From: Junio C Hamano <gitster@pobox.com>
To: Git List <git@vger.kernel.org>
Cc: "René Scharfe" <l.s.r@web.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
"Koji Nakamaru" <koji.nakamaru@gree.net>
Subject: Re: [PATCH] config.mak.uname: use iconv from Homebrew on macOS
Date: Thu, 11 Dec 2025 18:59:08 +0900 [thread overview]
Message-ID: <xmqqfr9he3v7.fsf@gitster.g> (raw)
In-Reply-To: <xmqqecp1hhi7.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 11 Dec 2025 11:36:16 +0900")
Junio C Hamano <gitster@pobox.com> writes:
> "brian m. carlson" <sandals@crustytoothpaste.net> writes:
>
>> On 2025-12-09 at 19:35:34, René Scharfe wrote:
>>> The library function iconv(3) supplied with macOS versions 15.7.2
>>> (Sequoia) and 26.1 (Tahoe) is unreliable when doing conversions from
>>> ISO-2022-JP to UTF-8 in multiple steps; t3900 reports this breakage:
>>>
>>> not ok 17 - ISO-2022-JP should be shown in UTF-8 now
>>> not ok 25 - ISO-2022-JP should be shown in UTF-8 now
>>> not ok 38 - commit --fixup into ISO-2022-JP from UTF-8
>>>
>>> As a workaround, use libiconv from Homebrew, if available.
>>
>> I like this solution, since it means when Apple ships their own Git
>> (which doesn't use Homebrew), they will be incentivized to fix the
>> problem since the test fails.
>
> Well, their build without Homebrew would fail with or without this
> patch, no? It is a good thing either way ;-)
Does anybody know if a purely vanilla installation of macOS, without
any third-party software collection like homebrewk, is supposed to
be even serviceable? That is, if somebody at Apple builds a version
of Git that they ship themselves (they do, don't they?), can they
untar the latest tarball on a vanilla macOS box, type "make test",
and expect it to pass?
Are there folks in the audience, with stakes in having such a thing
working, whether working for Apple or not, listening? Can you
perhaps help us to get to that point? The effort would involve (1)
fixing bugs in their own system, like this iconv issue, (2) marking
some part of the expectation unachievable by sprinkling !macOS
prerequisite in our tests, if bugs in their system like iconv cannot
be fixed for some reason, and (3) once we get to the point of
passing all tests, have a CI job to make sure we will stay clean.
Or do folks in macOS ecosystem already do something similar but
outside this mailing list, and it is useless for me to attempt to
help them?
next prev parent reply other threads:[~2025-12-11 9:59 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-08 22:59 t3900 failure on macOS, iconv(3) broken? René Scharfe
2025-12-09 3:18 ` Koji Nakamaru
2025-12-09 3:50 ` Yee Cheng Chin
2025-12-09 4:03 ` Collin Funk
2025-12-09 16:33 ` Torsten Bögershausen
2025-12-09 19:35 ` René Scharfe
2025-12-09 21:24 ` Torsten Bögershausen
2025-12-09 22:25 ` René Scharfe
2025-12-09 19:35 ` [PATCH] config.mak.uname: use iconv from Homebrew on macOS René Scharfe
2025-12-09 20:39 ` Yee Cheng Chin
2025-12-09 21:27 ` René Scharfe
2025-12-10 11:17 ` Carlo Marcelo Arenas Belón
2025-12-10 17:56 ` René Scharfe
2025-12-11 2:53 ` Junio C Hamano
2025-12-11 11:17 ` Carlo Marcelo Arenas Belón
2025-12-12 2:20 ` Junio C Hamano
2025-12-12 9:16 ` René Scharfe
2025-12-12 10:02 ` Carlo Marcelo Arenas Belón
2025-12-12 13:04 ` Re* " Junio C Hamano
2025-12-12 13:48 ` René Scharfe
2025-12-12 23:39 ` Junio C Hamano
2025-12-10 16:42 ` Torsten Bögershausen
2025-12-10 17:56 ` René Scharfe
2025-12-10 23:10 ` brian m. carlson
2025-12-11 2:36 ` Junio C Hamano
2025-12-11 9:59 ` Junio C Hamano [this message]
2025-12-11 14:34 ` René Scharfe
2025-12-12 3:35 ` Junio C Hamano
2025-12-12 10:40 ` t3900 failure on macOS, iconv(3) broken? René Scharfe
2025-12-13 18:42 ` [PATCH v2 1/2] Makefile: add NO_HOMEBREW René Scharfe
2025-12-14 6:45 ` Torsten Bögershausen
2025-12-14 7:13 ` Junio C Hamano
2025-12-14 9:02 ` Torsten Bögershausen
2025-12-14 11:07 ` Junio C Hamano
2025-12-14 11:13 ` René Scharfe
2025-12-14 23:19 ` Junio C Hamano
2025-12-16 18:53 ` René Scharfe
2025-12-13 18:42 ` [PATCH v2 2/2] config.mak.uname: use iconv from Homebrew on macOS René Scharfe
2025-12-16 18:53 ` [PATCH v3 1/2] macOS: make Homebrew use configurable René Scharfe
2025-12-16 19:11 ` René Scharfe
2025-12-16 21:49 ` Torsten Bögershausen
2025-12-16 18:53 ` [PATCH v3 2/2] macOS: use iconv from Homebrew if present René Scharfe
2025-12-24 7:52 ` [PATCH v4 0/2] macOS: use iconv from Homebrew if needed and present René Scharfe
2025-12-24 8:02 ` [PATCH v4 1/2] macOS: make Homebrew use configurable René Scharfe
2025-12-24 8:03 ` [PATCH v4 2/2] macOS: use iconv from Homebrew if needed and present René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfr9he3v7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=koji.nakamaru@gree.net \
--cc=l.s.r@web.de \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).