From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: git@vger.kernel.org, K Jayatheerth <jayatheerthkulkarni2005@gmail.com>
Subject: Re: [PATCH] submodule add: sanity check existing .gitmodules
Date: Tue, 25 Nov 2025 06:33:11 -0800 [thread overview]
Message-ID: <xmqqfra2tc60.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BES6HBGxXKC9sfBHu_5oBEDYD+aDquHtoDSZtZdaqOMBQ@mail.gmail.com> (Elijah Newren's message of "Mon, 24 Nov 2025 22:49:10 -0800")
Elijah Newren <newren@gmail.com> writes:
>> no definition of submodule.<name>.path variable, it accessing the
>
> accessing => tries to access
> (or accessing => accesses)
>> A helper used by update_submodule() seems to assume that its call to
>> submodule_from_path() always yields a submodule object without a
>> failure, which seems to rely on the caller's making sure it is the
>
> caller's => caller ?
Thanks.
prev parent reply other threads:[~2025-11-25 14:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-16 7:02 [PATCH] submodule add: sanity check existing .gitmodules Junio C Hamano
2025-11-25 6:49 ` Elijah Newren
2025-11-25 14:33 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfra2tc60.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jayatheerthkulkarni2005@gmail.com \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).