Re: [PATCH v4 0/3] clean up some code around editors

[Junio C Hamano <gitster@pobox.com>]

Phillip Wood <phillip.wood123@gmail.com> writes:

> Hi Ben
>
> On 12/08/2025 18:02, D. Ben Knoble wrote:
>> Changes from v3:
>> - drop 4/4
>> - use test_env (including a case our lint does not catch when the value
>>    has spaces)
>
> It's not worth a re-roll but for future reference
>
> 	test_env FOO=bar git commit --amend
>
> uses an extra process compared to
>
> 	FOO=bar git commit --amend
>
> which slows the test suite down for no real gain. We should only need
> to use test_env to set environment variables when calling a shell
> function. In the special case of test_must_fail it supports
>
> 	test_must_fail env FOO=bar git commit --amend
>
> which is widely used in our test suite

If this were some feature series, the story may be different, but
since the theme of the topic is "clean up", the above clean-up is
something that ought to be part of an update.  A clean-up topic
should not be adding things that need to be further cleaned up ;-)

Thank you, both of you, for writing and reviewing the series.