From: Junio C Hamano <gitster@pobox.com>
To: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
Cc: "Josh Soref" <gitgitgadget@gmail.com>,
git@vger.kernel.org, 陈建虎 <18230222379@163.com>,
陈建虎 <chenjianhu@kylinos.cn>
Subject: Re: [PATCH] modify the “foo" file path to "$PWD/bad-clone/sub/foo".
Date: Wed, 30 Jul 2025 08:09:05 -0700 [thread overview]
Message-ID: <xmqqfredn2b2.fsf@gitster.g> (raw)
In-Reply-To: <096f8beb-8156-49da-b905-3615bb6116c8@app.fastmail.com> (Kristoffer Haugsbakk's message of "Wed, 30 Jul 2025 09:38:33 +0200")
"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:
> On Wed, Jul 30, 2025, at 09:25, On Wed, Jul 30, 2025, at 09:25, 陈建虎 via GitGitGadget wrote:
>> From: =?UTF-8?q?=E9=99=88=E5=BB=BA=E8=99=8E?= <chenjianhu@kylinos.cn>
>> ...
>> Signed-off-by: chenjianhu <chenjianhu@kylinos.cn>
>
> The author name and signoff name should match. Either “陈建虎” or the
> (I’m guessing) romanization “chenjianhu” for both.
Yup, either is fine but it would be nicer to non-east-asian friends
to use the Anglicized form.
The title is what needs more polish than the name though.
next prev parent reply other threads:[~2025-07-30 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 7:25 [PATCH] modify the “foo" file path to "$PWD/bad-clone/sub/foo" 陈建虎 via GitGitGadget
2025-07-30 7:38 ` Kristoffer Haugsbakk
2025-07-30 15:09 ` Junio C Hamano [this message]
2025-07-30 15:47 ` Junio C Hamano
2025-07-30 18:08 ` Justin Tobler
2025-07-31 3:49 ` [PATCH v2] t7450: inspect the correct path a broken code would write to chenjianhu via GitGitGadget
2025-07-31 18:45 ` Junio C Hamano
2025-08-01 16:48 ` Justin Tobler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfredn2b2.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=18230222379@163.com \
--cc=chenjianhu@kylinos.cn \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kristofferhaugsbakk@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).