git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrik Weiskircher <patrik@pspdfkit.com>
Cc: git@vger.kernel.org,  apenwarr@gmail.com
Subject: Re: [PATCH 0/2] contrib/subtree: Add -S/--gpg-sign option
Date: Thu, 29 May 2025 16:15:19 -0700	[thread overview]
Message-ID: <xmqqfrgnhuuw.fsf@gitster.g> (raw)
In-Reply-To: <20250528130116.21534-1-patrik@pspdfkit.com> (Patrik Weiskircher's message of "Wed, 28 May 2025 09:01:14 -0400")

Patrik Weiskircher <patrik@pspdfkit.com> writes:

> Hi!
>
> We use git subtree a lot to manage our dependencies, but recently started
> requiring signed commits. This patch adds support for signing commits to
> git subtree.
>
> This is my first submission to the Git project - you don't have to be gentle,
> but please let me know if I can improve anything.

A few things ;-) starting from the log message where you didn't
quite add why we would want to do these changes.

Also, I think these two should be combined into a single patch.  We
add a feature and make sure the feature works correctly and we also
make sure that the feature does not misfire when the user does not
ask it to trigger, all in the same commit.

  parent reply	other threads:[~2025-05-29 23:15 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-28 13:01 [PATCH 0/2] contrib/subtree: Add -S/--gpg-sign option Patrik Weiskircher
2025-05-28 13:01 ` [PATCH 1/2] " Patrik Weiskircher
2025-05-29 23:45   ` Junio C Hamano
2025-05-28 13:01 ` [PATCH 2/2] contrib/subtree: Add tests for -S/--gpg-sign Patrik Weiskircher
2025-05-29 23:15 ` Junio C Hamano [this message]
2025-05-30 14:33   ` [PATCH 0/2] contrib/subtree: Add -S/--gpg-sign option Patrik Weiskircher
2025-05-30 20:55     ` Junio C Hamano
2025-06-02 13:12       ` Patrik Weiskircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrgnhuuw.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=patrik@pspdfkit.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).