git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org,  "brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH 09/34] howto/new-command: update reference to builtin docs
Date: Mon, 03 Mar 2025 13:59:26 -0800	[thread overview]
Message-ID: <xmqqfrjtvkqp.fsf@gitster.g> (raw)
In-Reply-To: <20250303204443.360595-10-tmz@pobox.com> (Todd Zullinger's message of "Mon, 3 Mar 2025 15:44:07 -0500")

Todd Zullinger <tmz@pobox.com> writes:

> Commit ec14d4ecb5 (builtin.h: take over documentation from
> api-builtin.txt, 2017-08-02) deleted api-builtin.txt and moved the
> contents into builtin.h.  Most of the references were fixed in
> d85e9448dd (new-command.txt: update reference to builtin docs,
> 2023-02-04), but one remained.  Fix it.
>
> Signed-off-by: Todd Zullinger <tmz@pobox.com>
> ---
>  Documentation/howto/new-command.adoc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

;-)  This is orthogonal to the txt-to-adoc gotcha but is a long
overdue fix to even older breakage.  Thanks for addressing it.

> diff --git a/Documentation/howto/new-command.adoc b/Documentation/howto/new-command.adoc
> index 880c51112b..ac73c98be7 100644
> --- a/Documentation/howto/new-command.adoc
> +++ b/Documentation/howto/new-command.adoc
> @@ -48,7 +48,7 @@ binary); this organization makes it easy for people reading the code
>  to find things.
>  
>  See the CodingGuidelines document for other guidance on what we consider
> -good practice in C and shell, and api-builtin.txt for the support
> +good practice in C and shell, and builtin.h for the support
>  functions available to built-in commands written in C.
>  
>  What every extension command needs

  reply	other threads:[~2025-03-03 21:59 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-03 20:43 [PATCH 00/34] misc *.txt -> *.adoc fixes Todd Zullinger
2025-03-03 20:43 ` [PATCH 01/34] t0450: " Todd Zullinger
2025-03-03 21:52   ` Junio C Hamano
2025-03-03 22:28     ` Todd Zullinger
2025-03-03 22:55       ` Junio C Hamano
2025-03-04  0:15         ` Todd Zullinger
2025-03-03 20:44 ` [PATCH 02/34] .gitattributes: more *.txt -> *.adoc updates Todd Zullinger
2025-03-03 20:44 ` [PATCH 03/34] doc: remove unneeded .gitattributes Todd Zullinger
2025-03-03 21:55   ` Junio C Hamano
2025-03-03 20:44 ` [PATCH 04/34] Makefile: update reference to technical/racy-git.adoc Todd Zullinger
2025-03-03 20:44 ` [PATCH 05/34] README: *.txt -> *.adoc fixes Todd Zullinger
2025-03-03 20:44 ` [PATCH 06/34] CodingGuidelines: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 07/34] MyFirstContribution: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 08/34] MyFirstObjectWalk: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 09/34] howto/new-command: update reference to builtin docs Todd Zullinger
2025-03-03 21:59   ` Junio C Hamano [this message]
2025-03-03 20:44 ` [PATCH 10/34] technical/partial-clone: update reference to rev-list-options.adoc Todd Zullinger
2025-03-03 20:44 ` [PATCH 11/34] doc: *.txt -> *.adoc fixes Todd Zullinger
2025-03-03 20:44 ` [PATCH 12/34] advice.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 13/34] apply.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 14/34] builtin.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 15/34] config.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 16/34] contrib/long-running-filter: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 17/34] diff.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 18/34] diffcore.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 19/34] fsck.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 20/34] list-objects-filter-options.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 21/34] object-name.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 22/34] parse-options.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 23/34] pseudo-merge.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 24/34] refs.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 25/34] setup.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 26/34] simple-ipc.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 27/34] t/helper/test-rot13-filter.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 28/34] t6012: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 29/34] t6434: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 30/34] trace2.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 31/34] trace2/tr2_sysenv.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 32/34] transport.h: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 33/34] unpack-trees.c: " Todd Zullinger
2025-03-03 20:44 ` [PATCH 34/34] xdiff: " Todd Zullinger
2025-03-03 23:46 ` [PATCH 00/34] misc " brian m. carlson
2025-03-03 23:48   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrjtvkqp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).