public inbox for git@vger.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Moumita <dhar61595@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/1] [GSOC]  Use unsigned type for bit flags in commit-reach.c
Date: Wed, 12 Feb 2025 13:16:16 -0800	[thread overview]
Message-ID: <xmqqfrkiuan3.fsf@gitster.g> (raw)
In-Reply-To: <20250212192841.8321-1-dhar61595@gmail.com> (Moumita's message of "Thu, 13 Feb 2025 00:58:39 +0530")

Moumita <dhar61595@gmail.com> writes:

> The `flags` variable holds multiple bitwise flags (PARENT1,
> PARENT2, STALE),these flags are defined using (1u << N), so maybe
> there will be no issues if it is changed from `int` to `unsigned
> int`

"This change will not break" is not a good reason to make the
change, though, as not making that change will not break anything,
either.

If you need to write something, say something that positively
justifies the change, explaining readers why it is a good thing to
do, and how the resulting code is _better_ than the original.

Thanks.


      parent reply	other threads:[~2025-02-12 21:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-12 19:28 [PATCH 0/1] [GSOC] Use unsigned type for bit flags in commit-reach.c Moumita
2025-02-12 19:28 ` [PATCH 1/1] commit-reach: use unsigned int for flags in paint_down_to_common() Moumita
2025-02-12 21:16 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrkiuan3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=dhar61595@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox