From: Junio C Hamano <gitster@pobox.com>
To: Ivan Shapovalov <intelfx@intelfx.name>
Cc: "D. Ben Knoble" <ben.knoble@gmail.com>,
git@vger.kernel.org, Elijah Newren <newren@gmail.com>,
Derrick Stolee <stolee@gmail.com>,
Alex Henrie <alexhenrie24@gmail.com>
Subject: Re: [PATCH] rebase: add `--update-refs=interactive`
Date: Tue, 11 Feb 2025 08:50:21 -0800 [thread overview]
Message-ID: <xmqqfrkk1l4i.fsf@gitster.g> (raw)
In-Reply-To: <bc0de52b59f289e1388f1581fcfa49453365e21a.camel@intelfx.name> (Ivan Shapovalov's message of "Tue, 11 Feb 2025 15:33:15 +0400")
Ivan Shapovalov <intelfx@intelfx.name> writes:
>> > --update-refs::
>> > --no-update-refs::
>> > +--update-refs=interactive::
>>
>> Based on `git grep -e '--.*\[=' Documentation/git-*.txt`, I think this
>> should be more like
>>
>> --update-refs[=interactive]::
>> --no-update-refs::
>>
>> But maybe that unintentionally suggests that `=interactive` is the default?
>
> Perhaps --update-refs[=(yes|no|interactive)] then? Or is that too
> verbose?
If `--update-refs` does take values that the git_parse_maybe_bool()
helper parses as a Boolean value, I do not think the above is
verbose at all. Rather, it is a disservice to the users if the
documentation does not mention yes/no in such a case. I'd say
listing other Boolean synonyms like yes/true/on/no/false/off is
too verbose, though ;-).
> Anyway, I don't have a preference, I'll just do what I'm told
That is not quite in line with how we'd like to operate.
It is your itch. Others may give suggestions to help you polish it,
but ultimately, we would not want to accept a patch that the author
does not agree with.
Thanks.
next prev parent reply other threads:[~2025-02-11 16:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-10 19:16 [PATCH] rebase: add `--update-refs=interactive` Ivan Shapovalov
2025-02-10 20:22 ` D. Ben Knoble
2025-02-11 11:33 ` Ivan Shapovalov
2025-02-11 16:50 ` Junio C Hamano [this message]
2025-02-11 17:36 ` Ivan Shapovalov
2025-02-11 19:28 ` D. Ben Knoble
2025-02-11 19:29 ` D. Ben Knoble
2025-02-11 14:36 ` Phillip Wood
2025-02-11 18:11 ` Ivan Shapovalov
2025-02-12 14:26 ` Phillip Wood
2025-02-12 16:58 ` Junio C Hamano
2025-02-13 9:43 ` Phillip Wood
2025-02-12 17:18 ` Ivan Shapovalov
2025-02-13 9:43 ` phillip.wood123
2025-02-13 12:04 ` Ivan Shapovalov
2025-02-19 14:52 ` phillip.wood123
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrkk1l4i.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=alexhenrie24@gmail.com \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=intelfx@intelfx.name \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).