git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Jan 2025, #05; Fri, 17)
Date: Tue, 21 Jan 2025 11:17:37 -0800	[thread overview]
Message-ID: <xmqqfrlc0yem.fsf@gitster.g> (raw)
In-Reply-To: <20250119125526.GA1540196@coredump.intra.peff.net> (Jeff King's message of "Sun, 19 Jan 2025 07:55:26 -0500")

Jeff King <peff@peff.net> writes:

> I was thinking to just leave the offending code untouched in the
> individual commands if we went this route.

Ah, I see.  Yeah, then we have a subtle and possibly brittle code
paths that are well contained inside two functions.

> But anyway, I'll prepare a version going the other get_be32() direction.

Thanks.  That probably results in better code with fewer magic.

THanks.

  reply	other threads:[~2025-01-21 19:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-18  0:42 What's cooking in git.git (Jan 2025, #05; Fri, 17) Junio C Hamano
2025-01-18 13:15 ` Jeff King
2025-01-18 17:17   ` Junio C Hamano
2025-01-19 12:51     ` Jeff King
2025-01-19 12:55       ` Jeff King
2025-01-21 19:17         ` Junio C Hamano [this message]
2025-01-20  6:53 ` David Aguilar
2025-01-20  7:54   ` [PATCH] help: make help.autocorrect = 1 the same as "prompt" David Aguilar
2025-01-21 19:23   ` What's cooking in git.git (Jan 2025, #05; Fri, 17) Junio C Hamano
2025-01-21 20:19 ` Derrick Stolee
2025-01-21 20:30   ` Junio C Hamano
2025-01-22 18:30     ` Taylor Blau
2025-01-22 22:13       ` Junio C Hamano
2025-01-23 23:05         ` Taylor Blau
2025-01-23 23:46           ` Junio C Hamano
2025-01-22 16:44 ` Karthik Nayak
2025-01-22 17:28   ` Karthik Nayak
2025-01-22 17:38     ` Junio C Hamano
2025-01-23 17:22     ` Junio C Hamano
2025-01-23 17:45       ` Patrick Steinhardt
2025-01-23 18:25         ` Junio C Hamano
2025-01-24 11:05         ` Karthik Nayak
2025-01-24 17:06           ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrlc0yem.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).