From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Sam James <sam@gentoo.org>,
git@vger.kernel.org, Eli Schwartz <eschwartz@gentoo.org>
Subject: Re: [PATCH] meson: fix perl dependencies
Date: Wed, 08 Jan 2025 08:07:04 -0800 [thread overview]
Message-ID: <xmqqfrltnvbr.fsf@gitster.g> (raw)
In-Reply-To: <Z34Zv55SSDexBxHQ@pks.im> (Patrick Steinhardt's message of "Wed, 8 Jan 2025 07:22:55 +0100")
Patrick Steinhardt <ps@pks.im> writes:
> On Wed, Jan 08, 2025 at 03:42:37AM +0000, Sam James wrote:
>> `generate_perl_command` needs `depends: [git_version_file]` and the uses
>> in top-level meson.build were fine, but the ones in perl/ weren't, causing
>> parallel build failures in some cases as GIT-BUILD-OPTIONS wasn't yet
>> available.
>
> Thanks for your patch! The change looks obviously correct to me.
>
> Patrick
Thanks, both. Will fast-track to 'master' before the final gets
tagged, but we may want to advertise 'meson' support still as work
in progress in the release notes.
next prev parent reply other threads:[~2025-01-08 16:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 3:42 [PATCH] meson: fix perl dependencies Sam James
2025-01-08 6:22 ` Patrick Steinhardt
2025-01-08 16:07 ` Junio C Hamano [this message]
2025-01-08 16:13 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrltnvbr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=eschwartz@gentoo.org \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).