From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Rahul Rameshbabu <rrameshbabu@nvidia.com>,
Aaron Plattner <aplattner@nvidia.com>,
git@vger.kernel.org
Subject: Re: [PATCH v2] credential: clear expired c->credential, unify secret clearing
Date: Tue, 04 Jun 2024 22:12:48 -0700 [thread overview]
Message-ID: <xmqqfrtsynu7.fsf@gitster.g> (raw)
In-Reply-To: <87y17kbavu.fsf@nvidia.com> (Rahul Rameshbabu's message of "Tue, 04 Jun 2024 15:28:53 -0700")
Rahul Rameshbabu <rrameshbabu@nvidia.com> writes:
>>> Aaron Plattner <aplattner@nvidia.com> writes:
>> ...
>> Rahul (CC'd) and I had a series of patches to add something similar to the
>> current authtype system but hadn't gotten around to sending them to the list
>> before this more flexible mechanism was merged. It's nice that this worked out
>> of the box with minimal adjustment.
>>
>> The credential helper he wrote is specific to the Microsoft "Entra ID" identity
>> provider system, but hopefully it'll be generally useful once this stuff is in a
>> git release. It really cleans up the authentication process over https for sites
>> that support it.
>
> Aaron made a commit to make it work with the authtype/credential
> credential-helper infrastructure that landed in git-next.
>
> https://github.com/Binary-Eater/git-credential-msal/commit/f71ca9c72ca1a2cf73373de76909f6007ac689cb
>
> The support for authtype excites me since a number of large Git
> providers like GitHub/GitLab/etc. have utilized Authorization Basic
> incorrectly for supporting different authtypes with git previously.
> Hoping they will move away from this practice in the future with this
> enhancement.
Thanks for a huge praise that I do not personally deserve ;-) Kudos
go to brian and folks who helped reviewing his topic.
next prev parent reply other threads:[~2024-06-05 5:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-04 19:29 [PATCH v2] credential: clear expired c->credential, unify secret clearing Aaron Plattner
2024-06-04 20:51 ` Junio C Hamano
2024-06-04 21:21 ` brian m. carlson
2024-06-04 22:04 ` Junio C Hamano
2024-06-04 22:19 ` Aaron Plattner
2024-06-04 22:28 ` Rahul Rameshbabu
2024-06-05 5:12 ` Junio C Hamano [this message]
2024-06-05 8:57 ` Jeff King
2024-06-05 16:45 ` Aaron Plattner
2024-06-06 8:08 ` Jeff King
2024-06-05 17:06 ` Junio C Hamano
2024-06-06 8:10 ` Jeff King
2024-06-06 15:13 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfrtsynu7.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=aplattner@nvidia.com \
--cc=git@vger.kernel.org \
--cc=rrameshbabu@nvidia.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).