git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] gitlab-ci: add smoke test for fuzzers
Date: Mon, 29 Apr 2024 08:37:49 -0700	[thread overview]
Message-ID: <xmqqfrv4yyb6.fsf@gitster.g> (raw)
In-Reply-To: <Zi86uFE5RlDG2RFN@tanuki> (Patrick Steinhardt's message of "Mon, 29 Apr 2024 08:14:16 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> On Mon, Apr 29, 2024 at 08:13:23AM +0200, Patrick Steinhardt wrote:
>> Our GitLab CI setup has a test gap where the fuzzers aren't exercised at
>> all. Add a smoke test, similar to the one we have in GitHub Workflows.
>> 
>> Signed-off-by: Patrick Steinhardt <ps@pks.im>
>> ---
>> 
>> As identified by Junio in <xmqqwmoi31aw.fsf@gitster.g>.
>> 
>> Patrick
>
> I forgot to add the link to a successful run of this job:
> https://gitlab.com/gitlab-org/git/-/jobs/6735705569

Thanks.  I wonder if we can somehow automate a change like this.

Seeing how simple this fix has become thanks to the use of
before_script/script pair that merely point at ci/*.sh scripts,
perhaps we have already extracted enough commonalities as a set of
shell scripts in ci/ hierarchy.  I wonder if we can have a common
"source" that is "compiled" into .gitlab-ci.yml and its counterpart
for GitHub Actions?

Or perhaps a linter that can say things like "ah, you are adding
this new test to one, but not touching the other, shouldn't you?",
and "you are tweaking this existing test in one, but shouldn't you
be doing the same to the other?"



  reply	other threads:[~2024-04-29 15:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-29  6:13 [PATCH] gitlab-ci: add smoke test for fuzzers Patrick Steinhardt
2024-04-29  6:14 ` Patrick Steinhardt
2024-04-29 15:37   ` Junio C Hamano [this message]
2024-04-30  4:30     ` Patrick Steinhardt
2024-05-06 10:08 ` Patrick Steinhardt
2024-05-06 18:52   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrv4yyb6.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).