git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Jeff King <peff@peff.net>,  Linus Arver <linusa@google.com>,
	 Git mailing list <git@vger.kernel.org>
Subject: Re: [BUG] git commit --trailer --verbose puts trailer below scissors line
Date: Mon, 19 Feb 2024 10:42:45 -0800	[thread overview]
Message-ID: <xmqqfrxo9ty2.fsf@gitster.g> (raw)
In-Reply-To: <ca6a73d3-58b4-e65c-4a8f-e6ddb3e86902@gmail.com> (Philippe Blain's message of "Mon, 19 Feb 2024 12:41:13 -0500")

Philippe Blain <levraiphilippeblain@gmail.com> writes:

> Hi Peff,
>> ...
>> diff --git a/t/t7502-commit-porcelain.sh b/t/t7502-commit-porcelain.sh
>> index b5bf7de7cd..d8e216613f 100755
>> --- a/t/t7502-commit-porcelain.sh
>> +++ b/t/t7502-commit-porcelain.sh
>> @@ -485,6 +485,24 @@ test_expect_success 'commit --trailer not confused by --- separator' '
>>  	test_cmp expected actual
>>  '
>>  
>> +test_expect_success 'commit --trailer with --verbose' '
>> +	cat >msg <<-\EOF &&
>> +	subject
>> +
>> +	body
>> +	EOF
>> +	GIT_EDITOR=: git commit --edit -F msg --allow-empty \
>> +		--trailer="my-trailer: value" --verbose &&
>> +	{
>> +		cat msg &&
>> +		echo &&
>> +		echo "my-trailer: value"
>> +	} >expected &&
>> +	git cat-file commit HEAD >commit.msg &&
>> +	sed -e "1,/^\$/d" commit.msg >actual &&
>> +	test_cmp expected actual
>> +'
>> +
>>  test_expect_success 'multiple -m' '
>>  
>>  	>negative &&
>
> Thanks for the test case!
>
> Philippe.

Thanks, both, for finding a rather unfortunate regression.  Perhaps
it is worth delaying 2.44 final by a week or so to include a fix (or
a revert if it comes to it).



  reply	other threads:[~2024-02-19 18:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-16 21:04 [BUG] git commit --trailer --verbose puts trailer below scissors line Philippe Blain
2024-02-16 21:19 ` Junio C Hamano
2024-02-16 22:34 ` Linus Arver
2024-02-17  6:04 ` Jeff King
2024-02-19 17:41   ` Philippe Blain
2024-02-19 18:42     ` Junio C Hamano [this message]
2024-02-20  1:09       ` [PATCH] trailer: fix comment/cut-line regression with opts->no_divider Jeff King
2024-02-20  3:26         ` Junio C Hamano
2024-03-08  2:21         ` Linus Arver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfrxo9ty2.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=levraiphilippeblain@gmail.com \
    --cc=linusa@google.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).