git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Raúl Núñez de Arenas Coronado" <raulnac@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: Fwd: Unexpected behavior of ls-files command when using --others --exclude-from, and a .gitignore file which resides in a subdirectory
Date: Mon, 22 Jan 2024 12:52:46 -0800	[thread overview]
Message-ID: <xmqqfryprsyp.fsf@gitster.g> (raw)
In-Reply-To: <CAGF1KhWiYX=3R01Odj2yCNgvx=f5+HRCjRJogWf5eBikuATCcg@mail.gmail.com> ("Raúl Núñez de Arenas Coronado"'s message of "Mon, 22 Jan 2024 21:45:46 +0100")

Raúl Núñez de Arenas Coronado <raulnac@gmail.com> writes:

> In short: using 'git ls-files --others
> --exclude-from=subdir/.gitignore' results in an empty listing if
> subdir/.gitignore contains '*". IMHO that pattern should be applied to
> the subdir contents ...

I do not think so.

Imagine what would happen then if you did

    $ cp subdir/.gitignore /var/tmp/1
    $ git ls-files --others --exclude-from=/var/tmp/1

in such a repository?  The "--exclude-from" option is used to name
the contents (set of patterns) that should be used and the path of
the file that happens to contain the contents does not matter.  So
you should get the same output as the ls-files command that was told
to use "--exclude-from=subdir/.gitignore".

  reply	other threads:[~2024-01-22 20:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAGF1KhWNaO_TUuCPo2L_HzNnR+FnB1Q4H6_xQ2owoH+SnynzEg@mail.gmail.com>
2024-01-22 20:45 ` Fwd: Unexpected behavior of ls-files command when using --others --exclude-from, and a .gitignore file which resides in a subdirectory Raúl Núñez de Arenas Coronado
2024-01-22 20:52   ` Junio C Hamano [this message]
2024-01-22 21:07     ` Raúl Núñez de Arenas Coronado
2024-01-22 21:42       ` Junio C Hamano
2024-01-23  6:08         ` Raúl Núñez de Arenas Coronado
2024-01-22 21:34   ` Jeff King
2024-01-22 21:45     ` Junio C Hamano
2024-01-22 21:59       ` Jeff King
2024-01-24  2:58         ` Elijah Newren
2024-01-24 17:06           ` Junio C Hamano
2024-01-24 18:57             ` Jeff King
2024-01-23  5:40     ` Raúl Núñez de Arenas Coronado
2024-01-24  1:09       ` Jeff King
2024-01-24 14:22         ` Raúl Núñez de Arenas Coronado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfryprsyp.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=raulnac@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).