git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <me@ttaylorr.com>
Cc: git@vger.kernel.org,  Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] pack-bitmap: drop --unpacked non-commit objects from results
Date: Tue, 07 Nov 2023 11:20:45 +0900	[thread overview]
Message-ID: <xmqqfs1ib8xu.fsf@gitster.g> (raw)
In-Reply-To: <7492dc699052a392d2fb394e1dcfabebac82ded0.1699311386.git.me@ttaylorr.com> (Taylor Blau's message of "Mon, 6 Nov 2023 17:56:33 -0500")

Taylor Blau <me@ttaylorr.com> writes:

The same comment to the commit title applies here.

> .... Note that we do not have to
> inspect individual bits in the result bitmap, since we know that the
> first N (where N is the number of objects in the bitmap's pack/MIDX)
> bits correspond to objects which packed by definition.

;-)

Very nice.  Since we are omitting any object that appears in some
packfile, this produces an expected result even when some of these
objects also appear in loose form.

> +test_expect_success 'bitmap traversal with --unpacked' '
> +	git repack -adb &&
> +	test_commit unpacked &&
> +
> +	git rev-list --objects --no-object-names unpacked^.. >expect.raw &&
> +	sort expect.raw >expect &&
> +
> +	git rev-list --use-bitmap-index --objects --all --unpacked >actual.raw &&
> +	sort actual.raw >actual &&
> +
> +	test_cmp expect actual
> +'

OK.


  reply	other threads:[~2023-11-07  2:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-06 22:56 [PATCH 0/2] revision: exclude all packed objects with `--unpacked` Taylor Blau
2023-11-06 22:56 ` [PATCH 1/2] list-objects: drop --unpacked non-commit objects from results Taylor Blau
2023-11-07  2:21   ` Junio C Hamano
2023-11-07  4:02     ` Jeff King
2023-11-06 22:56 ` [PATCH 2/2] pack-bitmap: " Taylor Blau
2023-11-07  2:20   ` Junio C Hamano [this message]
2023-11-07  3:52   ` Jeff King
2023-11-07  1:42 ` [PATCH 0/2] revision: exclude all packed objects with `--unpacked` Junio C Hamano
2023-11-07  4:02 ` Jeff King
2023-11-07  9:43   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfs1ib8xu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).