From: Junio C Hamano <gitster@pobox.com>
To: Naomi Ibe <naomi.ibeh69@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2 1/1] [OUTREACHY] add: standardize die() messages output.
Date: Tue, 17 Oct 2023 12:41:26 -0700 [thread overview]
Message-ID: <xmqqfs29hw9l.fsf@gitster.g> (raw)
In-Reply-To: <20231017113946.747-1-naomi.ibeh69@gmail.com> (Naomi Ibe's message of "Tue, 17 Oct 2023 12:39:45 +0100")
Naomi Ibe <naomi.ibeh69@gmail.com> writes:
> builtin/add.c: clean up die() messages
>
> As described in the CodingGuidelines document, a single line
> message given to die() and its friends should not capitalize its
> first word, and should not add full-stop at the end.
>
> Signed-off-by: Naomi Ibe <naomi.ibeh69@gmail.com>
That's a strange formatting. I think you meant to make the first
line (i.e. "builtin/add.c:...") as the Subject: of the e-mail, and
the three lines of text as the body, without any indentation.
Will queue with such a fix locally to save time, but please make
sure you know what in your workflow to produce a patch and send it
out caused this strange formatting, so that you can fix it and send
your patches correctly when you need to do so for real.
Thanks.
next prev parent reply other threads:[~2023-10-17 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 11:39 [PATCH v2 1/1] [OUTREACHY] add: standardize die() messages output Naomi Ibe
2023-10-17 19:41 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 22:06 Naomi Ibe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfs29hw9l.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=naomi.ibeh69@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).