From: Junio C Hamano <gitster@pobox.com>
To: Joanna Wang <jojwang@chromium.org>
Cc: git@vger.kernel.org
Subject: Re: Supporting `git add -a <exclude submodules>`
Date: Thu, 28 Sep 2023 11:24:08 -0700 [thread overview]
Message-ID: <xmqqfs2yjgvr.fsf@gitster.g> (raw)
In-Reply-To: <xmqqsf6yjhhm.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 28 Sep 2023 11:11:01 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> By the way, I am surprised that "diff.ignoreSubmodules=all" is
> abused by anybody that way. It depends on the implementation detail
> that we internally use the diff machinery to find which paths are
> not modified, and I would even say it is a BUG that "commit -a" pays
> attention to the configuration variable that way. I would recommend
> strongly to stay away from that approach or your tools will get
> broken when the bug gets fixed.
Sorry, but I take this part back. This is an explicitly documented
feature of the variable, so users and scripts alike should be able
to depend on. It still feels like a layering violation, but it is
too late to "fix" it now.
next prev parent reply other threads:[~2023-09-28 18:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 17:06 Supporting `git add -a <exclude submodules>` Joanna Wang
2023-09-28 18:11 ` Junio C Hamano
2023-09-28 18:16 ` Junio C Hamano
2023-09-28 18:24 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-17 20:59 Joanna Wang
2023-10-17 21:36 ` Junio C Hamano
2023-10-17 22:48 Joanna Wang
2023-10-17 23:02 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfs2yjgvr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jojwang@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).