git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Hugo Sales via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Hugo Sales <hugo@hsal.es>
Subject: Re: [PATCH] Add `restore.defaultLocation` option
Date: Sun, 12 Mar 2023 14:32:38 -0700	[thread overview]
Message-ID: <xmqqfsa9y7t5.fsf@gitster.g> (raw)
In-Reply-To: <pull.1467.git.git.1678578153640.gitgitgadget@gmail.com> (Hugo Sales via GitGitGadget's message of "Sat, 11 Mar 2023 23:42:33 +0000")

"Hugo Sales via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Hugo Sales <hugo@hsal.es>
>
> This options allows control over which of `--worktree` or `--staged` is
> applied when `git restore` is invoked with neither

We do not want to do this.  Tutorials and documents will be written
assuming the official default, and those users who set it to use a
different default, only because they are told to use it before they
know better, would waste a lot of time wondering why the procedures
they read from tutorials and documents would not work for them.
Even an expert who is asked to help a novice, who has this variable
set, would end up getting confused becaue "git restore" without the
explict options does not work as they expect.

Individual users are welcome to use "[alias] ri = restore --staged"
and this will hurt nobody.

  reply	other threads:[~2023-03-12 21:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-11 23:42 [PATCH] Add `restore.defaultLocation` option Hugo Sales via GitGitGadget
2023-03-12 21:32 ` Junio C Hamano [this message]
2023-03-13 18:02   ` Junio C Hamano
2023-03-13 23:11 ` Junio C Hamano
2023-03-14 23:51   ` Hugo Sales
2023-03-26 10:53     ` Hugo Sales

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfsa9y7t5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=hugo@hsal.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).