git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Michael Herrmann <michael@herrmann.io>
Cc: "brian m. carlson" <sandals@crustytoothpaste.net>, git@vger.kernel.org
Subject: Re: A puzzle: reset --hard and hard links
Date: Mon, 24 Jan 2022 13:19:07 -0800	[thread overview]
Message-ID: <xmqqfspc3k8k.fsf@gitster.g> (raw)
In-Reply-To: <CABrKpmB7UEGzLCiNHQtY5-Dt16jLkpcpBEx3o8y9OBGZ418keA@mail.gmail.com> (Michael Herrmann's message of "Mon, 24 Jan 2022 15:16:43 -0300")

Michael Herrmann <michael@herrmann.io> writes:

>> It is merely because you helped Git to realize
>
> I don't want to "help Git realize". I'm sorry but in my opinion `git
> status` should not have any effects on other commands. I don't
> understand how you can argue that calling `git status` is a valid fix
> to "help Git".
>
>> With another step 1.5 "append a line to the file in question", git
>> should severe the link,
>
> I don't want to sever the hard link. I want to avoid that it gets severed.

Sorry, if that is the case, what you want is not a version control,
and it is certainly not Git.  You want something else.

Think about this scenario.

    $ rm -fr one && git init one && cd one
    $ echo 0 >a; echo 0 >b; git add a b; git commit -m zero

We have two files, a and b, each of which has "0" in it.

    $ echo 1 >b; git add b; git commit -m one

Now they have "0" and "1" respectively.

    $ echo 2 >a; echo 2 >b; git commit -a -m two
    $ ln -f a b
    $ git diff
    $ git diff HEAD

Now they have "2".  Since they have identical contents, "diff" would
report no difference relative to the index or HEAD, even after we
manually break the working tree by making one of them a hardlink to
the other.

Now, what should this command do?

    $ git reset --hard HEAD^

What the user is asking is (1) to move the branch to point at the
previous commit, which had 0 and 1 in a and b respectively, and (2)
to make sure that the index and the working tree contents match what
is recorded in the commit.

So for Git to be a usefully correct version control system, it is
essential to make sure what it writes out would not affect any path
other than the one it is writing out.  When it writes "0" to "a", it
MUST break the hardlink from elsewhere that points at "a" before it
does so.  Otherwise, the "0" it writes into "a" will also be seen
elsewhere, which is not what the updated HEAD (i.e. commit "one")
wants to see.  The same for "b" when it is updated from "2" to "1"
when this happens.


  reply	other threads:[~2022-01-24 21:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19 20:37 A puzzle: reset --hard and hard links Michael Herrmann
2022-01-19 22:20 ` brian m. carlson
2022-01-19 22:37   ` Junio C Hamano
2022-01-20  8:59     ` Michael Herrmann
2022-01-20 22:20       ` brian m. carlson
2022-01-21 12:50         ` Michael Herrmann
2022-01-24 13:48           ` Michael Herrmann
2022-01-24 18:07             ` Junio C Hamano
2022-01-24 18:16               ` Michael Herrmann
2022-01-24 21:19                 ` Junio C Hamano [this message]
2022-01-24 21:50                   ` Michael Herrmann
2022-01-25  8:49                     ` Andreas Schwab
2022-01-25 11:33                     ` Ævar Arnfjörð Bjarmason
2022-01-25 13:29                       ` Andreas Schwab
2022-01-25 14:30                         ` Michael Herrmann
2022-01-26  2:14                           ` brian m. carlson
2022-01-26 18:46                             ` Junio C Hamano
2022-01-24 22:18                   ` rsbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfspc3k8k.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=michael@herrmann.io \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).