git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: David Aguilar <davvid@gmail.com>
Cc: "Felipe Contreras" <felipe.contreras@gmail.com>,
	"Git Mailing List" <git@vger.kernel.org>,
	"SZEDER Gábor" <szeder.dev@gmail.com>
Subject: Re: [PATCH v2 try2 0/4] completion: bash: a bunch of fixes
Date: Mon, 07 Jun 2021 10:08:32 +0900	[thread overview]
Message-ID: <xmqqfsxuwkfj.fsf@gitster.g> (raw)
In-Reply-To: <CAJDDKr4Wm2FQ-kq8k8EU6wE20V6ghuKDrzC5PcsZ6We0bMz3uQ@mail.gmail.com> (David Aguilar's message of "Sun, 6 Jun 2021 17:46:06 -0700")

David Aguilar <davvid@gmail.com> writes:

> On Sun, Jun 6, 2021 at 11:51 AM Felipe Contreras
> ...
> I tested this series on:
> - GNU bash, version 4.2.46(2)-release (x86_64-redhat-linux-gnu)
> - GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin19)
> - zsh 5.0.2 (x86_64-redhat-linux-gnu)
> - zsh 5.7.1 (x86_64-apple-darwin19.0)
> and can confirm that it is an improvement.
>
> FWIW,
> Tested-by: David Aguilar <davvid@gmail.com>

Thanks, will queue (I haven't checked if there is any overlap with
what is cooking above 'master', so it may not happen very soon,
though).

  reply	other threads:[~2021-06-07  1:08 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-06 18:47 [PATCH v2 try2 0/4] completion: bash: a bunch of fixes Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-07 19:00   ` SZEDER Gábor
2021-06-07 19:11     ` Felipe Contreras
2021-06-08  5:15       ` Junio C Hamano
2021-06-08  5:49         ` Felipe Contreras
2021-06-06 18:47 ` [PATCH v2 try2 4/4] completion: bash: add correct suffix in variables Felipe Contreras
2021-06-07  0:46 ` [PATCH v2 try2 0/4] completion: bash: a bunch of fixes David Aguilar
2021-06-07  1:08   ` Junio C Hamano [this message]
2021-06-08  6:00 ` [PATCH v3 " Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 1/4] completion: bash: fix prefix detection in branch.* Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 2/4] completion: bash: fix for suboptions with value Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 3/4] completion: bash: fix for multiple dash commands Felipe Contreras
2021-06-08  6:00   ` [PATCH v3 4/4] completion: bash: add correct suffix in variables Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqfsxuwkfj.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=davvid@gmail.com \
    --cc=felipe.contreras@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).