From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re* [PATCH v2 2/2] CoC: update to version 2.0 + local changes
Date: Mon, 04 Jan 2021 15:47:30 -0800 [thread overview]
Message-ID: <xmqqft3g463x.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: xmqqmtxxedwd.fsf@gitster.c.googlers.com
Junio C Hamano <gitster@pobox.com> writes:
> Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
>
>> This change intentionally preserves a warning emitted on "git diff
>> --check". It's better to make it easily diff-able with upstream than
>> to fix whitespace changes in our version while we're at it.
>
> I think there are only two lines that needs to tolerate trailing
> whitespaces, and even if we strip them, it should be still easily
> diff-able with the upstream with --ignore-space-at-eol or whatever
> appropriate option, so I am not sure if it is worth try "keeping"
> these whitespace breakage.
In the meantime, I'll insert this as step [1.5/2] while queuing.
In any case, your [2/2] lacks your sign-off, which we eventually
need to have before applying these patches. In the meantime, we
also need to collect Acks on the move to 2.0 from folks.
Thanks.
---- >8 -------- >8 -------- >8 -------- >8 -------- >8 ----
Subject: [PATCH] CoC: explicitly take any whitespace breakage
We'll keep this document mostly in sync with the upstream; let's
help "git am" and "git show" by telling them that they may introduce
what we may consider whitespace errors.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
.gitattributes | 1 +
1 file changed, 1 insertion(+)
diff --git a/.gitattributes b/.gitattributes
index b08a1416d8..b0044cf272 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -6,6 +6,7 @@
*.pm eol=lf diff=perl
*.py eol=lf diff=python
*.bat eol=crlf
+CODE_OF_CONDUCT.md -whitespace
/Documentation/**/*.txt eol=lf
/command-list.txt eol=lf
/GIT-VERSION-GEN eol=lf
--
2.30.0-170-g148fa4353e
next prev parent reply other threads:[~2021-01-04 23:48 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-28 12:59 [PATCH] CoC: update to 2.0 Junio C Hamano
2020-12-28 15:18 ` Derrick Stolee
2020-12-28 17:02 ` brian m. carlson
2020-12-28 17:17 ` [PATCH v2 0/2] CoC: update to 2.0 with less upstream divergence Ævar Arnfjörð Bjarmason
2020-12-28 17:17 ` [PATCH v2 1/2] CoC: Update word-wrapping to match upstream Ævar Arnfjörð Bjarmason
2020-12-29 3:11 ` Jonathan Nieder
2021-01-04 23:43 ` Junio C Hamano
2020-12-28 17:17 ` [PATCH v2 2/2] CoC: update to version 2.0 + local changes Ævar Arnfjörð Bjarmason
2020-12-28 22:58 ` Junio C Hamano
2020-12-29 2:02 ` Elijah Newren
2020-12-29 18:36 ` Derrick Stolee
2020-12-30 8:20 ` Christian Couder
2021-01-04 23:47 ` Junio C Hamano [this message]
2021-01-07 23:28 ` Re* " Johannes Schindelin
2021-01-08 0:41 ` Junio C Hamano
2021-01-08 1:57 ` brian m. carlson
2020-12-29 3:17 ` Jonathan Nieder
2020-12-28 17:32 ` [PATCH] CoC: update to 2.0 Ævar Arnfjörð Bjarmason
2020-12-28 22:43 ` Junio C Hamano
2020-12-28 18:40 ` Emily Shaffer
2020-12-29 8:54 ` Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft3g463x.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).