From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: VenomVendor <info@venomvendor.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
git@vger.kernel.org
Subject: Re: [PATCH 4/3] am, sequencer: stop parsing our own committer ident
Date: Mon, 26 Oct 2020 10:12:45 -0700 [thread overview]
Message-ID: <xmqqft60gbci.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <20201023072630.GA2918369@coredump.intra.peff.net> (Jeff King's message of "Fri, 23 Oct 2020 03:26:30 -0400")
Jeff King <peff@peff.net> writes:
> By the way, I wondered why we needed to do this parsing at all. The
> patch below does this in a much simpler way. It's a little bit ugly, I
> think, because we have to call getenv() ourselves. But that's the way
> fmt_ident() has always worked. We could probably improve that now that
> it takes a whose_ident flag (before that, it had no idea if we wanted
> author or committer ident).
>
> This is on top of the fixes (but we'd perhaps just want to do those on
> 'maint' as the minimal fix).
This could be the nicest step in the whole series, but let's leave
it out of the branch meant for 'maint'.
Thanks.
next prev parent reply other threads:[~2020-10-26 17:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 5:48 committer-date-is-author-date flag removes email in "Commit" VenomVendor
2020-10-23 7:07 ` Jeff King
2020-10-23 7:08 ` [PATCH 1/3] t3436: check --committer-date-is-author-date result more carefully Jeff King
2020-10-23 10:10 ` Phillip Wood
2020-10-23 7:09 ` [PATCH 2/3] am: fix broken email with --committer-date-is-author-date Jeff King
2020-10-23 7:26 ` [PATCH 4/3] am, sequencer: stop parsing our own committer ident Jeff King
2020-10-23 7:45 ` Jeff King
2020-10-23 17:29 ` Taylor Blau
2020-10-26 16:25 ` Johannes Schindelin
2020-10-27 7:23 ` Jeff King
2020-10-23 14:06 ` Phillip Wood
2020-10-26 17:12 ` Junio C Hamano [this message]
2020-10-27 7:24 ` Jeff King
2020-10-23 7:10 ` [PATCH 3/3] rebase: fix broken email with --committer-date-is-author-date Jeff King
2020-10-23 15:23 ` committer-date-is-author-date flag removes email in "Commit" Junio C Hamano
2020-10-23 17:32 ` Phillip Wood
2020-10-23 17:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqft60gbci.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=info@venomvendor.com \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).