From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Ali Utku Selen <auselen@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] shallow.c: Don't free unallocated slabs
Date: Wed, 02 Oct 2019 15:01:42 +0900 [thread overview]
Message-ID: <xmqqftkbfzy1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20191001150729.GI10875@sigill.intra.peff.net> (Jeff King's message of "Tue, 1 Oct 2019 11:07:29 -0400")
Jeff King <peff@peff.net> writes:
> ... This is really an internal implementation
> detail of how the slab code works. It would be nice if callers didn't
> have to care about it. Perhaps we ought to have a slab foreach()
> function that encapsulates this, which would let this caller do
> something like:
>
> commit_depth_foreach(&depths, free_commit_depth);
> commit_depth_clear(&depths);
>
> But since this is the only place that looks into the slab in this way,
> I'm happy to take your much simpler fix in the meantime.
Likewise. Thanks, both.
prev parent reply other threads:[~2019-10-02 6:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 23:33 [PATCH] shallow.c: Don't free unallocated slabs Ali Utku Selen
2019-10-01 15:07 ` Jeff King
2019-10-02 6:01 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqftkbfzy1.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=auselen@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).