git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] travis-ci: ignore already tested trees in debug mode
Date: Fri, 20 Sep 2019 11:03:48 -0700	[thread overview]
Message-ID: <xmqqftkqvo8r.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190919173514.24074-1-szeder.dev@gmail.com> ("SZEDER Gábor"'s message of "Thu, 19 Sep 2019 19:35:14 +0200")

SZEDER Gábor <szeder.dev@gmail.com> writes:

>  skip_good_tree () {
> +	if test "$TRAVIS_DEBUG_MODE" = true
> +	then
> +		return
> +	fi

I think you convinced readers why it is a good idea to avoid
skipping an already tested tree, and technically the title of this
commit is not incorrect per-se.  You are teaching to ignore
"already-tested-ness" from a part of the logic).

But in the larger picture, I would expect that readers would more
immediately grasp what it is about if it were titled "do not skip
versions that have already tested good in debug mode" or something
like that (IOW, we do not want to ignore such trees, we want to test
them again).


  reply	other threads:[~2019-09-20 18:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-19 17:35 [PATCH] travis-ci: ignore already tested trees in debug mode SZEDER Gábor
2019-09-20 18:03 ` Junio C Hamano [this message]
2019-09-20 18:17   ` SZEDER Gábor
2019-09-20 18:28     ` Junio C Hamano
2019-09-20 21:56       ` SZEDER Gábor
2019-09-21  7:40       ` [PATCH v2] travis-ci: do not skip successfully " SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftkqvo8r.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=szeder.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).