git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Alex Henrie <alexhenrie24@gmail.com>,
	git@vger.kernel.org, sunshine@sunshineco.com
Subject: Re: [PATCH v2] Give git-pull a --reset option
Date: Mon, 22 Apr 2019 08:38:26 +0900	[thread overview]
Message-ID: <xmqqftqb9bf1.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <20190421211833.GC6316@genre.crustytoothpaste.net> (brian m. carlson's message of "Sun, 21 Apr 2019 21:18:33 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> It may be helpful to point out that this is essentially the workflow I
> had ...
> I'm not sure if this email is an argument for or against this option,
> but maybe it provides some helpful perspective.

I think you and Phillip misread me.

I did not question if the workflow is common the message you are
responding to.  I've done my fair share of "I know what I have on my
laptop is stale as I pushed it out to elsewhere to continue working
on it, so let's get rid of it from the updated upstream and start
afresh" myself.

What I questioned was if it is sensible to ensure that it stays
common.

We'd be encouraging the dangerous workflow, instead of analysing the
situation where people employ it and trying to give them a better
alternative to deal with the situation.  That is what we'd be doing
with "pull --reset", i.e. an easier to type short-hand that robs the
chance to double check in the middle of "fetch && inspect && reset"
sequence.

As to where the feature should go, if we decide that it is a good
idea to promote this workflow element as a supported feature, I
agree with Alex's design in the patch that it makes sense to have it
as "pull --reset".  Existing "pull --merge" and "pull -rebase" are
"fetch and then integrate by merging theirs into ours" and "fetch
and then integrate by rebasing our stuff on top of theirs"; the new
"pull --reset" would fit well sitting next to them with its "fetch
and then treat our stuff as valueless and replace it with theirs"
semantics.

  reply	other threads:[~2019-04-21 23:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21  4:08 [PATCH v2] Give git-pull a --reset option Alex Henrie
2019-04-21  5:38 ` Junio C Hamano
2019-04-21  7:01   ` Alex Henrie
2019-04-21 13:53     ` Philip Oakley
2019-04-21 21:18   ` brian m. carlson
2019-04-21 23:38     ` Junio C Hamano [this message]
2019-04-22 15:14       ` Phillip Wood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqftqb9bf1.fsf@gitster-ct.c.googlers.com \
    --to=gitster@pobox.com \
    --cc=alexhenrie24@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).