From: Junio C Hamano <gitster@pobox.com>
To: Duy Nguyen <pclouds@gmail.com>
Cc: Albert Burt <aburthinds@gmail.com>,
Git Mailing List <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>
Subject: Re: [PATCH v2] doc: remove unneeded TODO for release_commit_memory
Date: Wed, 02 Jan 2019 23:21:55 -0800 [thread overview]
Message-ID: <xmqqftuai4to.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CACsJy8B4FCkrV0srm8pvcU41DMWoZwDHgW8Wu0j3nZT5JLhEBA@mail.gmail.com> (Duy Nguyen's message of "Wed, 2 Jan 2019 18:17:44 +0700")
Duy Nguyen <pclouds@gmail.com> writes:
> On Wed, Jan 2, 2019 at 3:09 AM Albert Burt <aburthinds@gmail.com> wrote:
>>
>> Remove TODO that was left in from:
>> commit 110240588d (Merge branch 'sb/object-store-alloc' - 2018-06-25)
>>
>> Todo can be removed as:
>> 9d2c97016f (commit.h: delete 'util' field in struct commit - 2018-05-19)
>> deletes commit->util.
>>
>> Signed-off-by: Albert Burt <aburthinds@gmail.com>
>> ---
>>
>> Thanks for looking at this for me Duy. I updated some of the changes you
>> suggested.
>>
>> Let me know if there's anything else that I would need to clean up, or do better.
>> :)
>
> Nope. The patch looks good to me.
Yes, but we'll fix this with 6a7895fd ("commit: prepare
free_commit_buffer and release_commit_memory for any repo",
2018-12-14) anyway, so I am not sure if this is worth pursuing
separately.
>
>>
>> commit.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/commit.c b/commit.c
>> index 2d94e0b199..2ff6dca0bc 100644
>> --- a/commit.c
>> +++ b/commit.c
>> @@ -357,8 +357,6 @@ void release_commit_memory(struct commit *c)
>> c->index = 0;
>> free_commit_buffer(c);
>> free_commit_list(c->parents);
>> - /* TODO: what about commit->util? */
>> -
>> c->object.parsed = 0;
>> }
>>
>> --
>> 2.17.2 (Apple Git-113)
>>
prev parent reply other threads:[~2019-01-03 7:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-31 23:57 [PATCH] doc: remove unneeded TODO for release_commit_memory Albert Burt
2019-01-01 10:40 ` Duy Nguyen
2019-01-01 20:08 ` [PATCH v2] " Albert Burt
2019-01-02 11:17 ` Duy Nguyen
2019-01-03 7:21 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqftuai4to.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=aburthinds@gmail.com \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).