From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: "Galan Rémi" <remi.galan-alfonso@ensimag.grenoble-inp.fr>,
"Git List" <git@vger.kernel.org>,
"Remi Lespinet" <remi.lespinet@ensimag.grenoble-inp.fr>,
"Guillaume Pages" <guillaume.pages@ensimag.grenoble-inp.fr>,
"Louis-Alexandre Stuber"
<louis--alexandre.stuber@ensimag.grenoble-inp.fr>,
"Antoine Delaite" <antoine.delaite@ensimag.grenoble-inp.fr>,
"Johannes Schindelin" <johannes.schindelin@gmx.de>,
"Stefan Beller" <sbeller@google.com>,
"Philip Oakley" <philipoakley@iee.org>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Stephen Kelly" <steveire@gmail.com>
Subject: Re: [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits
Date: Tue, 02 Jun 2015 10:17:26 -0700 [thread overview]
Message-ID: <xmqqfv6a3u8p.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <vpq7frmy5nl.fsf@anie.imag.fr> (Matthieu Moy's message of "Tue, 02 Jun 2015 08:40:30 +0200")
Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> Galan Rémi <remi.galan-alfonso@ensimag.grenoble-inp.fr> writes:
>
>> Check if commits were removed (i.e. a line was deleted) and print
>> warnings or abort git rebase according to the value of the
>> configuration variable rebase.checkLevel.
>
> checkLevel does not seem to be a good name, because it doesn't say
> _what_ is checked. I don't have really good proposal in mind, but maybe
>
> rebase.todoListCheckLevel
> rebase.missinLinesCheckLevel
Yeah, with s/sin/sing/, but the above makes more sense. It may be
that we probably do not even need "Level" there in the name.
next prev parent reply other threads:[~2015-06-02 17:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 11:52 [PATCH/RFCv2 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-01 11:52 ` [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-01 23:16 ` Eric Sunshine
2015-06-01 23:17 ` Eric Sunshine
2015-06-02 7:42 ` Remi Galan Alfonso
2015-06-02 13:41 ` Eric Sunshine
2015-06-02 13:51 ` Remi Galan Alfonso
2015-06-02 6:40 ` Matthieu Moy
2015-06-02 9:23 ` Remi Galan Alfonso
2015-06-02 17:17 ` Junio C Hamano [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-06-03 11:44 [PATCH/RFCv4 1/2] git-rebase -i: add command "drop" to remove a commit Galan Rémi
2015-06-03 11:44 ` [PATCH/RFCv4 2/2] git rebase -i: warn about removed commits Galan Rémi
2015-06-03 19:14 ` [PATCH/RFCv2 " Eric Sunshine
2015-06-03 20:09 ` Remi Galan Alfonso
2015-06-06 23:45 ` Remi Galan Alfonso
2015-06-01 9:57 [PATCH/RFCv2 0/2] rebase -i : drop command and " Galan Rémi
2015-06-01 9:57 ` [PATCH/RFCv2 2/2] git rebase -i: warn about " Galan Rémi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqfv6a3u8p.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=antoine.delaite@ensimag.grenoble-inp.fr \
--cc=git@vger.kernel.org \
--cc=guillaume.pages@ensimag.grenoble-inp.fr \
--cc=johannes.schindelin@gmx.de \
--cc=louis--alexandre.stuber@ensimag.grenoble-inp.fr \
--cc=philipoakley@iee.org \
--cc=remi.galan-alfonso@ensimag.grenoble-inp.fr \
--cc=remi.lespinet@ensimag.grenoble-inp.fr \
--cc=sbeller@google.com \
--cc=steveire@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox