From: Junio C Hamano <gitster@pobox.com>
To: "Christian Noé Ramos López" <chris@nortesoftware.dev>
Cc: git@vger.kernel.org, Phillip Wood <phillip.wood@dunelm.org.uk>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] gpg-interface: fail when the ssh revocation file is missing
Date: Thu, 22 Oct 2026 08:56:39 -0700 [thread overview]
Message-ID: <xmqqh5idiv9k.fsf@gitster.g> (raw)
In-Reply-To: <20261022054607.766255-1-chris@nortesoftware.dev> ("Christian Noé Ramos López"'s message of "Thu, 22 Oct 2026 01:46:07 -0400")
Christian Noé Ramos López <chris@nortesoftware.dev> writes:
> When gpg.ssh.revocationFile names a file that does not exist, Git
> warns and runs ssh-keygen without it, so a signature made with a key
> listed in the intended revocation file verifies as good. A revocation
> ...
> gpg.ssh.revocationFile had no tests. Add tests for a revoked key, with
> and without ":(optional)", and for a missing file, with and without
> the prefix.
>
> Suggested-by: Patrick Steinhardt <ps@pks.im>
> Helped-by: Phillip Wood <phillip.wood@dunelm.org.uk>
> Helped-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Christian Noé Ramos López <chris@nortesoftware.dev>
> ---
Can you stick to the expected flow: (1) send v1 (2) get review
comments on v1 (3) respond to these review messages and then (4)
send v2 AS A DIRECT REPLY TO v1?
Sending the reroll as a response to v1 is important for automation
on the receiving end. Thanks.
prev parent reply other threads:[~2026-10-22 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 6:56 ssh signing: valid-before is checked at the signer's own date, and a missing revocationFile fails open Christian Noé Ramos López
2026-10-08 13:42 ` Phillip Wood
2026-10-09 12:19 ` Patrick Steinhardt
2026-10-09 13:30 ` Phillip Wood
[not found] ` <CAHGSfba9Td+Lg=Nf+nfwZY2r1_eq2Mcejn__6X=VPQkmcJttfQ@mail.gmail.com>
2026-10-09 13:29 ` Phillip Wood
2026-10-21 3:03 ` [PATCH] doc: gpg: say which date SSH key lifetimes are checked against Christian Noé Ramos López
2026-10-21 18:14 ` Junio C Hamano
2026-10-22 5:44 ` [PATCH v2] " Christian Noé Ramos López
2026-10-22 6:25 ` [PATCH] " Patrick Steinhardt
2026-10-21 4:17 ` [PATCH] gpg-interface: fail when the ssh revocation file is missing Christian Noé Ramos López
2026-10-21 18:40 ` Junio C Hamano
2026-10-22 5:46 ` [PATCH v2] " Christian Noé Ramos López
2026-10-22 15:56 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5idiv9k.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=chris@nortesoftware.dev \
--cc=git@vger.kernel.org \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox