From: Junio C Hamano <gitster@pobox.com>
To: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Elijah Newren <newren@github.com>
Subject: Re: [PATCH] diff: avoid misleading statement about -l option
Date: Wed, 12 Aug 2026 07:22:45 -0700 [thread overview]
Message-ID: <xmqqh5kzzadm.fsf@gitster.g> (raw)
In-Reply-To: <pull.2035.git.1786516958048.gitgitgadget@gmail.com> (Elijah Newren via GitGitGadget's message of "Wed, 12 Aug 2026 06:42:37 +0000")
"Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Elijah Newren <newren@github.com>
>
> In commit 6623a528e00b (doc: clarify documentation for rename/copy
> limits, 2021-07-15), the wording around rename limit options and config
> variables were updated to point out that only the quadratic portion of
> rename detection (or "exhaustive portion of rename/copy detection" as
> used in that commit) was limited by these options, because exact rename
> detection and basename-guided rename detection (which both run in time
> linear in the number of files) still run before this limit is checked.
>
> However, the short help message wasn't updated at the time; update it
> too.
However this is an end-user facing message. Can we make it more
easier to understnad by being less precise? "limit to exact
rename/copy if ..." or something?
next prev parent reply other threads:[~2026-08-12 14:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 6:42 [PATCH] diff: avoid misleading statement about -l option Elijah Newren via GitGitGadget
2026-08-12 14:22 ` Junio C Hamano [this message]
2026-08-12 15:42 ` Elijah Newren
2026-08-14 2:06 ` [PATCH v2] " Elijah Newren via GitGitGadget
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5kzzadm.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox