From: Junio C Hamano <gitster@pobox.com>
To: Pushkar Singh <pushkarkumarsingh1970@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] t1410: check files and missing paths after reflog rewind
Date: Sun, 11 Jan 2026 10:41:32 -0800 [thread overview]
Message-ID: <xmqqh5ssouub.fsf@gitster.g> (raw)
In-Reply-To: <20260111140417.36274-1-pushkarkumarsingh1970@gmail.com> (Pushkar Singh's message of "Sun, 11 Jan 2026 14:03:27 +0000")
Pushkar Singh <pushkarkumarsingh1970@gmail.com> writes:
> Subject: [PATCH] t1410: check files and missing paths after reflog rewind
That sounds as if the original did not check these things after
"reflog rewind" and this patch is about correcting it, doesn't it?
That is a bit different from what is really happening in this patch.
> Replace raw `test -f` and `! test -f` checks in the rewind test with
> `test_path_is_file` and `test_path_is_missing`. This provides clearer
> failure diagnostics and keeps the test consistent with the rest of
> the test suite.
On the other hand, this describes what the patch does nicely.
next prev parent reply other threads:[~2026-01-11 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-11 14:03 [PATCH] t1410: check files and missing paths after reflog rewind Pushkar Singh
2026-01-11 18:41 ` Junio C Hamano [this message]
2026-01-11 19:07 ` [PATCH v2] t1410: use test helpers in reflog rewind test Pushkar Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5ssouub.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=pushkarkumarsingh1970@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox