From: Junio C Hamano <gitster@pobox.com>
To: Bello Olamide <belkid98@gmail.com>
Cc: git@vger.kernel.org, christian.couder@gmail.com,
usmanakinyemi202@gmail.com
Subject: Re: [RFC Outreachy] Teach ci/check-whitespace to flag incomplete lines as an error
Date: Mon, 13 Oct 2025 08:41:03 -0700 [thread overview]
Message-ID: <xmqqh5w23j3k.fsf@gitster.g> (raw)
In-Reply-To: <CAD=f0L-QAfMhBw1_RyLkpdntjPfu4M+temmawWGEZjAJn_iQdQ@mail.gmail.com> (Bello Olamide's message of "Mon, 13 Oct 2025 00:41:51 +0100")
Bello Olamide <belkid98@gmail.com> writes:
>> we want. We need a mechanism that notices and warns when a commit
>> makes a file, which used to end with a newline, end in an incomplete
>> line.
>
> Thank you for the clarity. This would mean to compare the relevant files in the
> current commit with its parent commit and report when the current commit removes
> the new line at the end of file which was present in the parent commit.
>
> But how about when a file is newly added and lacks the new line?
Yes, you should notice and flag any new incomplete line that did not
exist before that are added by the commit.
prev parent reply other threads:[~2025-10-13 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-11 14:24 [RFC Outreachy] Teach ci/check-whitespace to flag incomplete lines as an error Bello Caleb Olamide
2025-10-11 19:50 ` Junio C Hamano
2025-10-12 23:41 ` Bello Olamide
2025-10-13 15:41 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5w23j3k.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=belkid98@gmail.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=usmanakinyemi202@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).