From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 656B7156F20 for ; Fri, 3 Oct 2025 20:32:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759523566; cv=none; b=qXxsDJAnPfYaTQC6wkdydaNyLRBLXr+U+Td120GYnQ3/KeIpfyaMm/Ue1eVtut1o1AQ0O3rOfqdH0Sukfe0AnLhI+WHQ1p7tAhuS28hN2c3vKf8ObA8L2DaoUEcQlQ/aCrLU6vl+y5EM00Vmcz9kB2HaLC9RKtc/yR9HlIxlc+U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759523566; c=relaxed/simple; bh=dPmts9DdwPCY3lW00NgpjKo4gQ0jstW63xl7XMhR61Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=YAQRnF70UsU8kUIGbSnrdoV//EDd8AO1olI+lE/uXHW8ZlaWTIzdHCLeJLmKoySzHzzhRvqQkDKnRzSbHU3cr6QDNxWxDMxjTs+iLU6Nzbi/+MdLRJ0W/yq5arbMfYqqLmK8uXr5Ygip9LWGJy7CsoZquSCZsKaSzHvgExJP4U8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com; spf=pass smtp.mailfrom=pobox.com; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b=XfuOx8OC; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=O7pZYLte; arc=none smtp.client-ip=103.168.172.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=pobox.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pobox.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pobox.com header.i=@pobox.com header.b="XfuOx8OC"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="O7pZYLte" Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.phl.internal (Postfix) with ESMTP id 72228EC0679; Fri, 3 Oct 2025 16:32:43 -0400 (EDT) Received: from phl-frontend-02 ([10.202.2.161]) by phl-compute-02.internal (MEProxy); Fri, 03 Oct 2025 16:32:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pobox.com; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm1; t=1759523563; x=1759609963; bh=A7Fxk5P/+J YUc+46G2UDgVcMsRh560o6YKQXZyLqYzM=; b=XfuOx8OC/lJNR+QlQxzQTrO/f1 GeRNcpTFTy2ERSrSrciSN458+rL6eJaEn/hMmy8oaL7MovKQ/BX+UMATpHecf/P1 1gfO3bps+IM7kdmrvI0pU5paEacikRyfSJcBwDY12umpGmaycSHmewW9xctbjDjn QFPq+T1QKPS+Yk6pbKhNSsB+8w5xhLRdhw6u25gMndwwfFowr+oUW5etFq6S6+ju A1E1TviSlj0Sy1+GTQGBjCi1hKVtUTYl5P2Q57MSeGYNArUsiNZRgnif72DIryb5 YEeW+8x03IDvczUGp9QGUqpc+XDulpxy2ZKHwVRZe60+n/kvFi9sSnJ86VlA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1759523563; x=1759609963; bh=A7Fxk5P/+JYUc+46G2UDgVcMsRh560o6YKQ XZyLqYzM=; b=O7pZYLte5m/tnCHBwtUjXeM6FRw8NrNNivDAKYIMj9ltroyuR0Z 0z3lHfNKIoIdFa1//kFoqzxhZrjHjn0Nwc7E2R/aOwOPqkDs0TuyzuP93fgMgT6+ oUg9ESdTrJP8FEqADP+N91ONEiA9qr4ewXiiG24/T5+ofcVCeIXcxYLRBZc0DIEp X9N98VW4lOTccg4q7FXLQ7Krhv+/b0e+bcSdrBxzf0VcuqsbuYIbvGIfi+dXOX7b +SLNtE259iFp39JhcK9BzKZftB5wfm1DvwiFPK5PYJ/BvaZC3wKm2GYdPyRQpuQC gcfp1M851IxqdATtnMBVvXE7X6H9oMgMoRg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggdekleekjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvfevufgjfhffkfgfgggtsehttdertddtredtnecuhfhrohhmpefluhhnihhoucev ucfjrghmrghnohcuoehgihhtshhtvghrsehpohgsohigrdgtohhmqeenucggtffrrghtth gvrhhnpeefveetteejheeugeffledvteeiveffueefjeelueffteeigffgfedthfefieeg ieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehgih htshhtvghrsehpohgsohigrdgtohhmpdhnsggprhgtphhtthhopedufedpmhhouggvpehs mhhtphhouhhtpdhrtghpthhtohepnhgvfihrvghnsehgmhgrihhlrdgtohhmpdhrtghpth htohepshhiugguhhgrrhhthhgrshhthhgrnhgrfedusehgmhgrihhlrdgtohhmpdhrtghp thhtohepghhithesvhhgvghrrdhkvghrnhgvlhdrohhrghdprhgtphhtthhopegthhhrih hsthhirghnrdgtohhuuggvrhesghhmrghilhdrtghomhdprhgtphhtthhopehpshesphhk shdrihhmpdhrtghpthhtoheptghouggvsehkhhgruhhgshgsrghkkhdrnhgrmhgvpdhrtg hpthhtoheprhihsggrkhdrrgdrvhesghhmrghilhdrtghomhdprhgtphhtthhopehkrghr thhhihhkrddukeeksehgmhgrihhlrdgtohhmpdhrtghpthhtohepjhhlthhosghlvghrse hgmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: if26b431b:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Oct 2025 16:32:42 -0400 (EDT) From: Junio C Hamano To: Elijah Newren Cc: Siddharth Asthana , git@vger.kernel.org, christian.couder@gmail.com, ps@pks.im, code@khaugsbakk.name, rybak.a.v@gmail.com, karthik.188@gmail.com, jltobler@gmail.com, toon@iotcl.com, johncai86@gmail.com, johannes.schindelin@gmx.de Subject: Re: [PATCH v2 1/1] replay: make atomic ref updates the default behavior In-Reply-To: (Elijah Newren's message of "Fri, 3 Oct 2025 12:48:39 -0700") References: <20250908043620.57848-1-siddharthasthana31@gmail.com> <20250926230838.35870-1-siddharthasthana31@gmail.com> <20250926230838.35870-2-siddharthasthana31@gmail.com> <0fba2f5e-03cd-439b-90bd-f613fcc4ae23@gmail.com> Date: Fri, 03 Oct 2025 13:32:41 -0700 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Precedence: bulk X-Mailing-List: git@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Elijah Newren writes: >> For naming, I am thinking either: >> - replay.updateRefs (boolean: true = update, false = output-commands) >> - replay.defaultOutput (string: "update" | "commands") >> >> The boolean feels simpler, but the string might be more extensible if we >> add other output modes later. Which pattern feels more consistent with >> existing Git config conventions? Looking at rebase.* they're mostly >> boolean toggles, but am I missing a better example to follow? > > replay.updateRefs sounds better to me. defaultOutput with "update" > doesn't make sense to me. Yup. Or "replay.defaultAction = (update-ref | show-comamnds)" if we anticipate that we might have a third option someday. That would of course affect the choice of the command line option.