From: Junio C Hamano <gitster@pobox.com>
To: "Jonas Brandstötter" <jonas.brandstoetter@gmx.at>
Cc: git@vger.kernel.org, Fabian Stelzer <fs@gigacodes.de>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2 0/2] gpg-interface: expand gpg.program as a path
Date: Tue, 22 Jul 2025 13:28:38 -0700 [thread overview]
Message-ID: <xmqqh5z4rmvd.fsf@gitster.g> (raw)
In-Reply-To: <20250722190922.51183-1-jonas.brandstoetter@gmx.at> ("Jonas Brandstötter"'s message of "Tue, 22 Jul 2025 21:09:20 +0200")
Jonas Brandstötter <jonas.brandstoetter@gmx.at> writes:
> Allows users to specify a custom gpg program in their home directory.
>
> V2 adds test cases for when the gpg program is not set as an absolute path.
> The test for gpg in a home directory feels a bit wonky to me, because it
> assumes that `~` is an alias for `$HOME` and just overriding that variable
> with the test directory. But short of creating a user while running the
> tests, this is the best solution I could come up with.
>
> Jonas Brandstötter (2):
> gpg-interface: expand gpg.program as a path
> t7510: add test cases for non-absolute gpg program
>
> Documentation/config/gpg.adoc | 2 +-
> gpg-interface.c | 2 +-
> t/t7510-signed-commit.sh | 12 +++++++++++-
> 3 files changed, 13 insertions(+), 3 deletions(-)
>
> Range-diff against v1:
> 1: b551903c16 = 1: b551903c16 gpg-interface: expand gpg.program as a path
> -: ---------- > 2: ca22bf2ee6 t7510: add test cases for non-absolute gpg program
> --
> 2.50.1
The first iteration of the patch was merged in the 'next' branch
long time ago, and then to the 'master' branch already. It is way
too late to wholesale replace the patch from the previous iteration.
It appears the first patch hasn't changed at all, so I'll just take
the second patch as a separate, follow-up topic to add a missing
test for already-graduated topic.
Thanks!
next prev parent reply other threads:[~2025-07-22 20:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-11 15:04 [BUG] gpg.program: '~' not expanded to home directory Ross MacArthur
2025-07-11 23:23 ` [PATCH] gpg-interface: expand gpg.program as a path Jonas Brandstötter
2025-07-14 17:10 ` Junio C Hamano
2025-07-22 19:09 ` [PATCH v2 0/2] " Jonas Brandstötter
2025-07-22 20:28 ` Junio C Hamano [this message]
2025-07-22 19:09 ` [PATCH v2 1/2] " Jonas Brandstötter
2025-07-22 19:09 ` [PATCH v2 2/2] t7510: add test cases for non-absolute gpg program Jonas Brandstötter
2025-07-25 4:30 ` Jeff King
2025-07-25 5:13 ` Jeff King
2025-07-29 0:05 ` Junio C Hamano
2025-07-29 7:12 ` Jeff King
2025-07-29 15:06 ` Junio C Hamano
2025-07-12 0:05 ` [BUG] gpg.program: '~' not expanded to home directory Junio C Hamano
2025-07-12 9:38 ` Andreas Schwab
2025-07-12 14:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh5z4rmvd.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=fs@gigacodes.de \
--cc=git@vger.kernel.org \
--cc=jonas.brandstoetter@gmx.at \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).