From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: git@vger.kernel.org, Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] meson: allow customize perl installation path
Date: Thu, 08 May 2025 07:34:29 -0700 [thread overview]
Message-ID: <xmqqh61v893e.fsf@gitster.g> (raw)
In-Reply-To: <a9d431944b6d94e0eb25535c061fc226a7fefa9e.1746692662.git.congdanhqx@gmail.com> ("Đoàn Trần Công Danh"'s message of "Thu, 8 May 2025 15:24:40 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> Some distros, notably Fedora, want to install non-core Perl libraries
> into specific directory, namely /usr/share/perl5/vendor_perl.
>
> The Makefile build system allows this by overriding perllibdir variable,
> let's make meson works on par with our Makefile.
>
> Signed-off-by: Đoàn Trần Công Danh <congdanhqx@gmail.com>
> ---
Will queue. The incremental since the previous iteration looks
exactly as Patrick suggested, which looks good to me, too.
Thanks.
> Range-diff against v1:
> 1: 14e38695adbd6 ! 1: a9d431944b6d9 meson: allow customize perl installation path
> @@ meson.build: if perl_features_enabled
> ## meson_options.txt ##
> @@
> +# Configuration for Git installation
> -+
> +option('perllibdir', type: 'string', value: '',
> -+ description: 'Directory to install perl lib to. Default to <datadir>/perl5')
> ++ description: 'Directory to install perl lib to. Defaults to <datadir>/perl5')
> +
> # Configuration for how Git behaves at runtime.
> option('default_pager', type: 'string', value: 'less',
prev parent reply other threads:[~2025-05-08 14:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 15:16 [PATCH] meson: allow customize perl installation path Đoàn Trần Công Danh
2025-04-25 6:25 ` Patrick Steinhardt
2025-05-08 8:24 ` [PATCH v2] " Đoàn Trần Công Danh
2025-05-08 14:34 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh61v893e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).