From: Junio C Hamano <gitster@pobox.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: Julian Swagemakers <julian@swagemakers.org>,
git@vger.kernel.org, M Hickford <mirth.hickford@gmail.com>,
sandals@crustytoothpaste.net, Shengyu Qu <wiagn233@outlook.com>
Subject: Re: [PATCH v3 3/3] send-email: add option to generate passswords like OAuth2 tokens
Date: Tue, 22 Apr 2025 15:20:49 -0700 [thread overview]
Message-ID: <xmqqh62f3kji.fsf@gitster.g> (raw)
In-Reply-To: <PN3PR01MB9597813722A475923ED1C036B8BB2@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM> (Aditya Garg's message of "Tue, 22 Apr 2025 15:23:21 +0000")
Aditya Garg <gargaditya08@live.com> writes:
> +--smtp-passeval[=<command>]::
> + Generate password or OAuth2 token for SMTP AUTH. The argument is
> + optional. If specified, it will use the output of any password
> + or OAuth2 token generated using the command specified.
> ++
> +Note that it will override any existing password specified using
> +`--smtp-user` or a `sendemail.smtpUser`.
If the argument is optional, we should explain what the behaviour is
when the optional argument is omitted, as well as how the given
argument is used. You are doing only the latter, but not the former.
Shouldn't the "command" be mandatory, if the option is used? I do
not quite see how these invocations
git-send-email ... --smtp-passeval ...
git-send-email ... --smtp-passeval= ...
that do not specify the command to be used is useful.
next prev parent reply other threads:[~2025-04-22 22:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 15:23 [PATCH v3 0/3] send-email: add oauth2 support and fix outlook breaking threads Aditya Garg
2025-04-22 15:23 ` [PATCH v3 1/3] send-email: implement SMTP bearer authentication Aditya Garg
2025-04-22 15:23 ` [PATCH v3 2/3] send-email: retrieve Message-ID from outlook SMTP server Aditya Garg
2025-04-22 22:05 ` Junio C Hamano
2025-04-23 3:22 ` Aditya Garg
2025-04-23 15:34 ` Junio C Hamano
2025-04-23 16:24 ` Aditya Garg
2025-04-22 15:23 ` [PATCH v3 3/3] send-email: add option to generate passswords like OAuth2 tokens Aditya Garg
2025-04-22 22:20 ` Junio C Hamano [this message]
2025-04-23 3:10 ` Aditya Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh62f3kji.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=gargaditya08@live.com \
--cc=git@vger.kernel.org \
--cc=julian@swagemakers.org \
--cc=mirth.hickford@gmail.com \
--cc=sandals@crustytoothpaste.net \
--cc=wiagn233@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox