Re: [PATCH v3 3/3] send-email: add option to generate passswords like OAuth2 tokens

Aditya Garg
2025-04-23T03:11:03Z

> On 23 Apr 2025, at 3:50 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
> ﻿Aditya Garg <gargaditya08@live.com> writes:
>
>> +--smtp-passeval[=<command>]::
>> + Generate password or OAuth2 token for SMTP AUTH. The argument is
>> + optional. If specified, it will use the output of any password
>> + or OAuth2 token generated using the command specified.
>> ++
>> +Note that it will override any existing password specified using
>> +`--smtp-user` or a `sendemail.smtpUser`.
>
> If the argument is optional, we should explain what the behaviour is
> when the optional argument is omitted, as well as how the given
> argument is used. You are doing only the latter, but not the former.
>

Argument is not optional. It's a left over line I had copied from above for the sake of formatting. My bad here.

> Shouldn't the "command" be mandatory, if the option is used? I do
> not quite see how these invocations
>
> git-send-email ... --smtp-passeval ...
> git-send-email ... --smtp-passeval= ...
>
> that do not specify the command to be used is useful.