git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eli Schwartz <eschwartz@gentoo.org>
Cc: git@vger.kernel.org,  Sam James <sam@gentoo.org>,
	 Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 1/6] meson: simplify and parameterize various standard function checks
Date: Mon, 21 Apr 2025 17:33:48 -0700	[thread overview]
Message-ID: <xmqqh62h591v.fsf@gitster.g> (raw)
In-Reply-To: <83d9fda5-8399-47fb-87b2-a8b376cf1625@gentoo.org> (Eli Schwartz's message of "Mon, 21 Apr 2025 16:04:30 -0400")

Eli Schwartz <eschwartz@gentoo.org> writes:

> On 4/21/25 1:51 PM, Eli Schwartz wrote:
>> This is repetitive logic. We either want to use some -lc function, or if
>> it is not available we define it as -DNO_XXX and usually (but not
>> always) provide some custom compatibility impl instead.
>> 
>> Checking the intent of each block when reading through the file is slow
>> and not very DRY. Switch to taking an array of checkable functions
>> instead.
>> 
>> Not all functions are straightforward to move, since different macro
>> prefixes are used.
>
>
> By the way, when reviewing this I was having a slightly hard time
> figuring out which stuff belonged here... specifically, because of the
> differences in macro prefixes lead me to believe it's not always so
> simple as "does it exist".


As there are non-zero number of meson related topics in flight, I'd
like to know where this new series is meant to apply, if you need
some of them before we can apply it, and what is the overall goal
this series has ("there is no theme, they are just random set of
changes to do such and such things" is perfectly acceptable answer).

And the best place to describe these things is in the cover letter
[PATCH 0/6] of the series.

Thanks.

  reply	other threads:[~2025-04-22  0:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-21 17:51 [PATCH 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-21 17:51 ` [PATCH 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-22  7:31   ` Patrick Steinhardt
2025-04-24 23:48   ` Junio C Hamano
2025-04-25  0:06     ` Eli Schwartz
2025-04-21 17:51 ` [PATCH 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-22  7:31   ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-22  7:31   ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-22  7:31   ` Patrick Steinhardt
2025-04-21 17:51 ` [PATCH 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-22  7:31   ` Patrick Steinhardt
2025-04-22 15:27     ` Eli Schwartz
2025-04-23 11:25       ` Patrick Steinhardt
2025-04-21 20:04 ` [PATCH 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-22  0:33   ` Junio C Hamano [this message]
2025-04-22  0:58     ` Eli Schwartz
2025-04-22  7:31   ` Patrick Steinhardt
2025-04-22 15:36     ` Eli Schwartz
2025-04-23 11:25       ` Patrick Steinhardt
2025-04-22  7:31 ` Patrick Steinhardt
2025-04-22 15:17   ` Junio C Hamano
2025-04-25  0:13 ` [PATCH v2 0/6] meson: miscellaneous system detection fixes Eli Schwartz
2025-04-25  0:13   ` [PATCH v2 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-25  0:13   ` [PATCH v2 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-25  0:13   ` [PATCH v2 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-25  0:13   ` [PATCH v2 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-25  0:13   ` [PATCH v2 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-25  0:13   ` [PATCH v2 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-25  4:39   ` [PATCH v2 0/6] meson: miscellaneous system detection fixes Patrick Steinhardt
2025-04-25  5:27     ` Eli Schwartz
2025-04-25  5:25 ` [PATCH v3 " Eli Schwartz
2025-04-25  5:25   ` [PATCH v3 1/6] meson: simplify and parameterize various standard function checks Eli Schwartz
2025-04-25  5:25   ` [PATCH v3 2/6] meson: check for getpagesize before using it Eli Schwartz
2025-04-25  5:25   ` [PATCH v3 3/6] meson: do a full usage-based compile check for sysinfo Eli Schwartz
2025-04-25  5:25   ` [PATCH v3 4/6] meson: add a couple missing networking dependencies Eli Schwartz
2025-04-25  5:25   ` [PATCH v3 5/6] meson: fix typo in function check that prevented checking for hstrerror Eli Schwartz
2025-04-25  5:25   ` [PATCH v3 6/6] meson: only check for missing networking syms on non-Windows; add compat impls Eli Schwartz
2025-04-25  9:53   ` [PATCH v3 0/6] meson: miscellaneous system detection fixes Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh62h591v.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=eschwartz@gentoo.org \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    --cc=sam@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).