From: Junio C Hamano <gitster@pobox.com>
To: Antonin Godard <antonin.godard@bootlin.com>
Cc: git@vger.kernel.org, "Emma Brooks" <me@pluvano.com>,
"Patrick Steinhardt" <ps@pks.im>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Daniel Li" <dan@danielyli.com>
Subject: Re: [PATCH RFC] builtin/log: include From in git show --format=email
Date: Fri, 14 Feb 2025 12:35:54 -0800 [thread overview]
Message-ID: <xmqqh64wl0wl.fsf@gitster.g> (raw)
In-Reply-To: <20250214-git-show-from-email-v1-1-df6469635454@bootlin.com> (Antonin Godard's message of "Fri, 14 Feb 2025 17:31:13 +0100")
Antonin Godard <antonin.godard@bootlin.com> writes:
> Currently, when the format.from and format.forceInBodyFrom options are
> configured, the command `git show --format=email <commit>` command does
> not include "From: user <email>" in the body, even though I believe it
> is expected when using this format.
Aren't "format.*" configuration variables for "git format-patch",
and not "git show" or "git log"?
I do not see there is anything that needs fixing, but I may be
missing something.
next prev parent reply other threads:[~2025-02-14 20:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 16:31 [PATCH RFC] builtin/log: include From in git show --format=email Antonin Godard
2025-02-14 20:35 ` Junio C Hamano [this message]
2025-02-17 12:42 ` Antonin Godard
2025-02-18 21:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh64wl0wl.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=antonin.godard@bootlin.com \
--cc=avarab@gmail.com \
--cc=dan@danielyli.com \
--cc=git@vger.kernel.org \
--cc=me@pluvano.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).