git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ramsay Jones <ramsay@ramsayjones.plus.com>
Cc: Jeff King <peff@peff.net>,
	 GIT Mailing-list <git@vger.kernel.org>,
	Patrick Steinhardt <ps@pks.im>,
	 Adam Dinwoodie <adam@dinwoodie.org>
Subject: Re: v2.46.0-rc0 test failures on cygwin
Date: Wed, 17 Jul 2024 21:52:18 -0700	[thread overview]
Message-ID: <xmqqh6cn1ev1.fsf@gitster.g> (raw)
In-Reply-To: <f97198e1-bfcc-4f3c-ad0a-2dd27d4f20cf@ramsayjones.plus.com> (Ramsay Jones's message of "Thu, 18 Jul 2024 02:22:30 +0100")

Ramsay Jones <ramsay@ramsayjones.plus.com> writes:

> On 18/07/2024 01:57, Jeff King wrote:
>> On Wed, Jul 17, 2024 at 07:05:43PM +0100, Ramsay Jones wrote:
> [snip]
>
>>> I also don't know the code well enough to answer your question regarding
>>> the re-opening of the migrated ref-store, but it doesn't look like it would
>>> cause any problems (famous last words).
>> 
>> Thanks for testing. This is new in the upcoming release, but I think
>> it's localized to the "git ref migrate" command. So aside from the
>> annoyance of the test failure for you, it is not too urgent. I'm tempted
>> to put it off until Patrick has had a chance to weigh in, even if it
>> means missing the v2.46 cutoff.
>
> Yes, I think it would be better for Patrick to take a look. I added Adam to
> the CC list to keep him in the loop (because he is the cygwin git package
> maintainer); he may have a view on the timing issues.
>
> Personally, I would be fine with a post v2.46 fix, but it is not up to me. :)

Thanks.  I am inclined to postpone it after 2.46 final, and not to
disturb Patrick during his honeymoon.


  reply	other threads:[~2024-07-18  4:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16 19:45 v2.46.0-rc0 test failures on cygwin Ramsay Jones
2024-07-17  6:42 ` Jeff King
2024-07-17 14:48   ` Junio C Hamano
2024-07-17 18:10     ` Ramsay Jones
2024-07-17 18:05   ` Ramsay Jones
2024-07-18  0:57     ` Jeff King
2024-07-18  1:22       ` Ramsay Jones
2024-07-18  4:52         ` Junio C Hamano [this message]
2024-07-21 13:48         ` Adam Dinwoodie
2024-07-23 10:30       ` Patrick Steinhardt
2024-07-23 20:49         ` Jeff King
2024-07-23 12:31 ` [PATCH] refs: fix format migration on Cygwin Patrick Steinhardt
2024-07-23 19:29   ` Ramsay Jones
2024-07-23 20:13     ` Junio C Hamano
2024-07-23 20:52   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh6cn1ev1.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=adam@dinwoodie.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=ps@pks.im \
    --cc=ramsay@ramsayjones.plus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).