From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Sean Allred <allred.sean@gmail.com>, git@vger.kernel.org
Subject: Re: [Q] rebase -i: turn "pick" to "edit", make no change, what should happen?
Date: Fri, 17 May 2024 08:17:55 -0700 [thread overview]
Message-ID: <xmqqh6ewmpr0.fsf@gitster.g> (raw)
In-Reply-To: <ZkcH-LAkLkf_wvfq@tanuki> (Patrick Steinhardt's message of "Fri, 17 May 2024 09:32:08 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> I quite frequently use "edit" just to inspect commits, stop at random
> points in the history, run tests and whatnot. So this would be a UX
> regression for me because I do not want to change commit messages and
> don't want to be bothered.
I sometimes (ab)use the "edit" exactly like that myself, so a
simple-minded unconditional change of behaviour would be a UX
regression to me as well.
> With the introduction of the "break" command you can certainly argue
> that "edit" is the wrong command to use in my case. Muscle memory is
> hard to retrain though :)
Yes, with a vim macro or its Emacs equivalent, it should be just as
easy as doing "s/^pick /edit /" to insert "break" after every line
that begins with "pick ", but "just as easy" is still an unwanted
forced change to the end-users. If I really wanted to, the right
and only way out is to introduce a new insn similar to "edit" but
behaves more like what I said earlier.
Thanks.
next prev parent reply other threads:[~2024-05-17 15:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 19:21 [Q] rebase -i: turn "pick" to "edit", make no change, what should happen? Junio C Hamano
2024-05-16 22:18 ` Sean Allred
2024-05-17 7:09 ` Junio C Hamano
2024-05-17 7:32 ` Patrick Steinhardt
2024-05-17 8:54 ` Dragan Simic
2024-05-17 13:52 ` Sean Allred
2024-05-17 15:17 ` Junio C Hamano [this message]
2024-05-17 12:42 ` Marc Branchaud
2024-05-17 17:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6ewmpr0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=allred.sean@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).