From: Junio C Hamano <gitster@pobox.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org, code@khaugsbakk.name, rjusto@gmail.com,
spectral@google.com
Subject: Re: [PATCH v2] branch: rework the descriptions of rename and copy operations
Date: Fri, 16 Feb 2024 13:45:27 -0800 [thread overview]
Message-ID: <xmqqh6i8gk20.fsf@gitster.g> (raw)
In-Reply-To: <608b4e81d71a95c820f1e4068382d391@manjaro.org> (Dragan Simic's message of "Fri, 16 Feb 2024 22:20:02 +0100")
Dragan Simic <dsimic@manjaro.org> writes:
>> But the halfway modification to the description section in this
>> patch is not an improvement. It makes some options described there
>> while -m and -c are completely missing now, making the section
>> incomplete and coverage of the operating modes of the command
>> uneven.
>
> If I got it right, you'd prefer this patch not to be accepted
> separately, but as part of the future series that would rework the
> entire git-branch(1) man page? I'm fine with that as well.
Not necessarily. If you wanted to this this in multiple steps, we
can first whip the OPTIONS part into a good shape, and then fix the
DESCRIPTION part.
What we want to avoid (not limited to this topic) is to say "this
temporarily makes things worse here, but trust me it will eventually
become perfect". Removing only -m/-c from the description section
makes the description section worse than before the patch---we'd be
better off leaving the original as-is if we are not revamping the
entire section.
next prev parent reply other threads:[~2024-02-16 21:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 12:44 [PATCH v2] branch: rework the descriptions of rename and copy operations Dragan Simic
2024-02-16 19:59 ` Junio C Hamano
2024-02-16 21:20 ` Dragan Simic
2024-02-16 21:45 ` Junio C Hamano [this message]
2024-02-16 21:58 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh6i8gk20.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=code@khaugsbakk.name \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=rjusto@gmail.com \
--cc=spectral@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).