git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, "D. Ben Knoble" <ben.knoble+github@gmail.com>
Subject: Re: [PATCH] i18n: mark more bundle.c strings for translation
Date: Thu, 13 Jul 2023 15:20:22 -0700	[thread overview]
Message-ID: <xmqqh6q7lahl.fsf@gitster.g> (raw)
In-Reply-To: <pull.1550.git.1689285683013.gitgitgadget@gmail.com> (D. Ben Knoble via GitGitGadget's message of "Thu, 13 Jul 2023 22:01:22 +0000")

"D. Ben Knoble via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: "D. Ben Knoble" <ben.knoble+github@gmail.com>
>
> These two messages were introduced in 8ba221e245 (bundle: output hash
> information in 'verify', 2022-03-22) and 105c6f14ad (bundle: parse
> filter capability, 2022-03-09) but never for translation.

Thanks for catching and reporting.

> diff --git a/bundle.c b/bundle.c
> index 8d5936c4212..a9744da255c 100644
> --- a/bundle.c
> +++ b/bundle.c
> @@ -271,10 +271,10 @@ int verify_bundle(struct repository *r,
>  			list_refs(r, 0, NULL);
>  		}
>  
> -		printf_ln("The bundle uses this hash algorithm: %s",
> +		printf_ln(_("The bundle uses this hash algorithm: %s"),
>  			  header->hash_algo->name);
>  		if (header->filter.choice)
> -			printf_ln("The bundle uses this filter: %s",
> +			printf_ln(_("The bundle uses this filter: %s"),
>  				  list_objects_filter_spec(&header->filter));

Looking good.  Will queue.

Thanks.

      reply	other threads:[~2023-07-13 22:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-13 22:01 [PATCH] i18n: mark more bundle.c strings for translation D. Ben Knoble via GitGitGadget
2023-07-13 22:20 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh6q7lahl.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=ben.knoble+github@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).