git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Phillip Wood <phillip.wood123@gmail.com>
Cc: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>,
	git@vger.kernel.org, "Elia Pinto" <gitter.spiros@gmail.com>,
	"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
	"Jeff King" <peff@peff.net>,
	"Phillip Wood" <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] tests: cache glibc version check
Date: Thu, 04 Aug 2022 13:20:55 -0700	[thread overview]
Message-ID: <xmqqh72r4v6g.fsf@gitster.g> (raw)
In-Reply-To: <53cffc06-ebb1-ac97-ceb4-4c242a82c68a@gmail.com> (Phillip Wood's message of "Thu, 4 Aug 2022 20:16:12 +0100")

Phillip Wood <phillip.wood123@gmail.com> writes:

> it. Having just read Peff's message this does not make much difference
> to the test timings and if I'd seen that before I wouldn't have posted
> this.

Ah, I forgot about that conclusion, i.e. while this does look the
right thing to do, it didn't make much difference in practice.

It still is tempting to take it, though :-), if only to stop people
sending in the same patch in the future without benchmarking, as
long as it does not make it worse.

Thanks.

  reply	other threads:[~2022-08-04 20:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-04 13:38 [PATCH] tests: cache glibc version check Phillip Wood via GitGitGadget
2022-08-04 14:26 ` Phillip Wood
2022-08-04 18:08 ` Junio C Hamano
2022-08-04 19:16   ` Phillip Wood
2022-08-04 20:20     ` Junio C Hamano [this message]
2022-08-04 20:41     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqh72r4v6g.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=avarab@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=gitter.spiros@gmail.com \
    --cc=peff@peff.net \
    --cc=phillip.wood123@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).