From: Junio C Hamano <gitster@pobox.com>
To: "Baumann, Moritz" <moritz.baumann@sap.com>
Cc: Moritz Baumann via GitGitGadget <gitgitgadget@gmail.com>,
"git@vger.kernel.org" <git@vger.kernel.org>,
Tao Klerks <tao@klerks.biz>
Subject: Re: [PATCH] git-p4: fix crlf handling for utf16 files on Windows
Date: Wed, 20 Jul 2022 10:18:47 -0700 [thread overview]
Message-ID: <xmqqh73b3doo.fsf@gitster.g> (raw)
In-Reply-To: <AS1PR02MB8185D1041A96B0384554EE32948E9@AS1PR02MB8185.eurprd02.prod.outlook.com> (Moritz Baumann's message of "Wed, 20 Jul 2022 16:32:51 +0000")
"Baumann, Moritz" <moritz.baumann@sap.com> writes:
> Do you need me to resubmit the patch with an explanatory
> description? If so, I can try to summarize the above.
Yup.
Review comments are not a request to the authors to explain their
patches to reviewers. Their primary purpose is to point out what
potential issues readers of the commit that would result by the
proposed patches may have. So answering in your response to see if
your clarifications are understandable is very good, but please
consider it a preparation to write a better version (i.e. [PATCH
v2]).
Thanks for working on this fix.
next prev parent reply other threads:[~2022-07-20 17:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 5:27 [PATCH] git-p4: fix crlf handling for utf16 files on Windows Moritz Baumann via GitGitGadget
2022-07-20 16:08 ` Junio C Hamano
2022-07-20 16:32 ` Baumann, Moritz
2022-07-20 17:18 ` Junio C Hamano [this message]
2022-07-20 18:17 ` [PATCH v2] git-p4: fix CR LF handling for utf16 files Moritz Baumann via GitGitGadget
2022-07-20 18:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqh73b3doo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=moritz.baumann@sap.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).